Page MenuHomeFreeBSD

[PowerPC] [BookE] Fix read past end of struct
ClosedPublic

Authored by bdragon on Oct 12 2019, 1:13 AM.
Referenced Files
F167614086: D21988.diff
Sun, Aug 23, 4:06 AM
Unknown Object (File)
Thu, Aug 20, 8:55 AM
Unknown Object (File)
Tue, Aug 18, 12:10 PM
Unknown Object (File)
Mon, Aug 17, 5:31 PM
Unknown Object (File)
Sun, Aug 16, 2:45 PM
Unknown Object (File)
Wed, Aug 12, 4:43 PM
Unknown Object (File)
Mon, Aug 10, 8:50 PM
Unknown Object (File)
Mon, Aug 10, 6:39 PM
Subscribers

Details

Summary

This was causing panics for me when using GCC 6.4.

Replace overly clever code that was reading past the end of a struct with a basic double loop.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdragon retitled this revision from [PowerPC] Fix read past end of struct to [PowerPC] [BookE] Fix read past end of struct.Oct 12 2019, 1:14 AM

Looks good for what we can do for now. I really should clean up the whole DPAA interface bits, so we don't need to do that loop. But since it's only executed on bootup, it's not a very high priority task.

This revision is now accepted and ready to land.Oct 12 2019, 8:29 PM
This revision was automatically updated to reflect the committed changes.