Page MenuHomeFreeBSD

[PowerPC] [BookE] Fix read past end of struct
ClosedPublic

Authored by bdragon on Oct 12 2019, 1:13 AM.
Referenced Files
Unknown Object (File)
Sun, Nov 24, 12:42 AM
Unknown Object (File)
Oct 24 2024, 11:27 AM
Unknown Object (File)
Oct 24 2024, 11:27 AM
Unknown Object (File)
Oct 24 2024, 11:27 AM
Unknown Object (File)
Oct 24 2024, 11:08 AM
Unknown Object (File)
Sep 16 2024, 12:42 PM
Unknown Object (File)
Sep 14 2024, 2:36 AM
Unknown Object (File)
Sep 8 2024, 7:48 AM
Subscribers

Details

Summary

This was causing panics for me when using GCC 6.4.

Replace overly clever code that was reading past the end of a struct with a basic double loop.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bdragon retitled this revision from [PowerPC] Fix read past end of struct to [PowerPC] [BookE] Fix read past end of struct.Oct 12 2019, 1:14 AM

Looks good for what we can do for now. I really should clean up the whole DPAA interface bits, so we don't need to do that loop. But since it's only executed on bootup, it's not a very high priority task.

This revision is now accepted and ready to land.Oct 12 2019, 8:29 PM
This revision was automatically updated to reflect the committed changes.