Page MenuHomeFreeBSD

extend in-tree toolchain check to suggest xtoolchain package
ClosedPublic

Authored by emaste on Sep 30 2019, 12:59 PM.

Details

Summary

If binutils/lld and GCC bootstraps are broken and we're not using Clang, suggest installing the xtoolchain-gcc package instead of just binutils.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Sep 30 2019, 12:59 PM

Previously we checked for only BINUTILS_BOOTSTRAP as a broken option and suggested installing the binutils package. This was originally done for arm64 where we used the in-tree Clang and external binutils package. Extend the warning to suggest instead the full xtoolchain package if we have no in-tree compiler either.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 8, 2:07 PM
This revision was automatically updated to reflect the committed changes.