Page MenuHomeFreeBSD

openat(2), mq_open(2): do not refer to mode_t for variadic arguments
ClosedPublic

Authored by greg_unrelenting.technology on Sep 27 2019, 12:25 PM.

Details

Summary
  • mode_t is uint16_t (sys/sys/_types.h)
  • openat takes variadic args
  • variadic args cannot be 16-bit, and indeed the code uses int
  • the manpage currently kinda implies the argument is 16-bit by saying mode_t

Prompted by Rust things: https://github.com/tailhook/openat/issues/21

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp accepted this revision.Sep 27 2019, 4:11 PM

LGTM

This revision is now accepted and ready to land.Sep 27 2019, 4:11 PM