openat(2), mq_open(2): do not refer to mode_t for variadic arguments
ClosedPublic
Actions

Authored by val_packett.cool on Sep 27 2019, 12:25 PM.

Details

Reviewers

Group Reviewers

Contributor Reviews (src)
manpages

Commits

rS352795: Document varadic args as int, since you can't have short varadic args (they are

Summary

mode_t is uint16_t (sys/sys/_types.h)
openat takes variadic args
variadic args cannot be 16-bit, and indeed the code uses int
the manpage currently kinda implies the argument is 16-bit by saying mode_t

Prompted by Rust things: https://github.com/tailhook/openat/issues/21

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool created this revision.Sep 27 2019, 12:25 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 27 2019, 12:25 PM

LGTM

This revision is now accepted and ready to land.Sep 27 2019, 4:11 PM

Closed by commit rS352795: Document varadic args as int, since you can't have short varadic args (they are (authored by imp). · Explain WhySep 27 2019, 4:12 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rS352795: Document varadic args as int, since you can't have short varadic args (they are.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

sys/

mq_open.2

2 lines

open.2

2 lines

Diff 62648

View Options

head/lib/libc/sys/mq_open.2