Page MenuHomeFreeBSD

devel/py-robotframework-pabot: Update to 0.87
ClosedPublic

Authored by Vladimir.Chukharev_gmail.com on Tue, Sep 10, 9:28 PM.

Details

Summary

Update devel/py-robotframework-pabot from 0.86 to 0.87, see PR 240481

Add tests. Upstream neither put nor plan to put the tests to the distributive package, and I had to checkout them using svn (or git). I've chosen svn.
I asked upstream if an additional package with tests can be made available. Now awaiting an answer.

Test Plan

portlint -Ca : OK
port test : OK
poudriere : OK (120Ramd64 py36)
make test : OK (also in a poudriere interactive jail)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kai added inline comments.Thu, Sep 12, 7:06 PM
devel/py-robotframework-pabot/Makefile
7 ↗(On Diff #61918)

This line needs to removed because we switch to GitHub further down.

20 ↗(On Diff #61918)

Should be removed, because the tests might work without it.

21 ↗(On Diff #61918)

We don't need subversion to checkout upstream's repository. We simply switch from PyPi (= CHEESESHOP) to GitHub for a while until upstream decides to distribute the test suite in the sdist for PyPi.

25 ↗(On Diff #61918)

By adding

USE_GITHUB=yes
GH_ACCOUNT=mkorpela
GH_PROJECT=pabot

you can use upstream's tarball that contains the test suite.

35 ↗(On Diff #61918)

Here's no need for svn, so this should be removed.

By looking at the run_tests.sh maybe the only following line will work instantly (haven't tested it, yet):

@cd ${WRKSRC} && ${PYTHON_CMD} -m nose tests/

or if the locale needs to be set:

@cd ${WRKSRC} && ${SETENV} LC_ALL=en_US.UTF-8 ${PYTHON_CMD} -m nose tests/

kai requested changes to this revision.Thu, Sep 12, 7:07 PM
This revision now requires changes to proceed.Thu, Sep 12, 7:07 PM
kai added a comment.Thu, Sep 12, 9:13 PM

Added small updates to some of my previous inline comments.

devel/py-robotframework-pabot/Makefile
20 ↗(On Diff #61918)

I meant only devel/py-virtualenv in the previous comment from above. It wasn't so clear after a second look.

35 ↗(On Diff #61918)

Meanwhile I was able to run the test suite successfully. Following oneliner should be used because the locale needs to be set and I forgot to mention the -v parameter to make the tests more verbose:

@cd ${WRKSRC} && ${SETENV} LC_ALL=en_US.UTF-8 ${PYTHON_CMD} -m nose -v tests/

Address comments by Kai Knoblich. Thanks, Kai!

Vladimir.Chukharev_gmail.com marked 7 inline comments as done.Fri, Sep 13, 9:26 AM
kai added a comment.Fri, Sep 13, 5:08 PM

The update will be ready soon to land. There's only one nitpick and a suggestion - both are added as inline comments.

devel/py-robotframework-pabot/Makefile
12 ↗(On Diff #62026)

You can add LICENSE_FILE=LICENSE.txt if you like because the license is available in the tarball from upstream's repository at GitHub. That license should be also packaged for the sdist where it's still missing at moment.

22–24 ↗(On Diff #62026)

Technically those lines are ok and do what they should. From the perspective regarding the style there's still a nitpick: Please add at least a tab after all the occurences of =.

Accept corrections from @kai (slightly changed).

Vladimir.Chukharev_gmail.com marked 2 inline comments as done.Fri, Sep 13, 7:49 PM
kai accepted this revision.Sat, Sep 14, 8:59 AM

Accept corrections from @kai (slightly changed).

Thanks, the diff looks good to me and I plan to commit it tonight.

This revision is now accepted and ready to land.Sat, Sep 14, 8:59 AM
This revision was automatically updated to reflect the committed changes.