Page MenuHomeFreeBSD

[new port] x11/libXpresent/: X11 Present library
ClosedPublic

Authored by madpilot on Wed, Sep 4, 8:23 PM.

Details

Summary

I created this patch while upgrading XFCE to 4.14.

The xfce4-wm port, containing xfce window manager, can link to this library using it as a backend for vsync.

I'd like to add it to the ports tree, so that, after the XFCE upgrade, I can enable support for it to the window manager.

I set x11 as port maintainer, is this acceptable?

Related xfce review: D21278

Test Plan

I have tested it in poudriere with tier 1 platforms, and tested with the xfce window manager from D21278 after adapting the port to use it.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

madpilot created this revision.Wed, Sep 4, 8:23 PM
madpilot edited the summary of this revision. (Show Details)Wed, Sep 4, 8:24 PM
linimon retitled this revision from Add libXpresent X11 library to [new port] x11/libXpresent/: X11 Present library.Fri, Sep 6, 12:06 AM
zeising requested changes to this revision.Fri, Sep 6, 4:00 PM
zeising added a subscriber: zeising.
zeising added inline comments.
x11/libXpresent/Makefile
16 ↗(On Diff #61660)

Should be USES=xorg-cat:lib

This revision now requires changes to proceed.Fri, Sep 6, 4:00 PM
madpilot marked an inline comment as done.Fri, Sep 6, 7:33 PM
madpilot updated this revision to Diff 61758.Fri, Sep 6, 7:33 PM

Fix USES.

zeising accepted this revision.Sat, Sep 7, 8:17 AM

Approved.
It makes sense to make the port owned by x11@
It doesn't need portmgr approval, Uses/xorg.mk is owned by x11@.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 10, 7:11 AM
Closed by commit rP511744: Add libXpresent: (authored by madpilot). · Explain Why
This revision was automatically updated to reflect the committed changes.