Page MenuHomeFreeBSD

makefs: use `char *` not `void *` for buf b_data and drop casts from msdos
ClosedPublic

Authored by emaste on Aug 20 2019, 9:57 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.Aug 20 2019, 9:57 PM
cem accepted this revision.Aug 20 2019, 10:03 PM

You've build-checked this, right? makefs/ffs has some casts of b_data to larger structure types, which are totally valid for void* but compilers may warn about casting from a lower-alignment type like char to a larger alignment type.

This revision is now accepted and ready to land.Aug 20 2019, 10:03 PM

You've build-checked this, right?

Yes on amd64.