ping: add tests of the Internet checksum function

[jansucan]

Summary

Add tests of the Internet checksum function

Submitted by: Ján Sučan <[e-mail]>
Sponsored by: Google LLC (Google Summer of Code 2019)

[asomers]

Don't forget to add an entry to etc/mtree/BSD.tests.dist

sbin/ping/tests/in_cksum_test.c

90

This doesn't guarantee that the array will be unaligned. It merely doesn't guarantee that it will be aligned. Better to declare an array that's aligned, then compute the checksum starting from the second byte. That way you'll know it's unaligned.

[jansucan]

Add an entry to etc/mtree/BSD.tests.dist.

Ensure an unaligned data by starting from the second byte of an aligned data buffer.

[jansucan]

sbin/ping/tests/in_cksum_test.c

90

Thanks. It has been fixed.

[asomers]

sbin/ping/tests/in_cksum_test.c

94

But now the second argument is wrong. Shouldn't it be nitems(data) - 1?

[jansucan]

Correct unaligned data buffer size.

[jansucan]

sbin/ping/tests/in_cksum_test.c

94

You're right. Thanks. I'm editing too many diffs at once.

[asomers]

sbin/ping/tests/Makefile

6

Here's a footgun you didn't know about: WARNS is by default set to 6 for libraries and binaries, but 0 for tests. You need to set it explicitly.

[jansucan]

Set WARNS to 6 explicitly for tests.

[jansucan]

sbin/ping/tests/Makefile

6

Fixed.