Add tests of the Internet checksum function
Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google LLC (Google Summer of Code 2019)
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Don't forget to add an entry to etc/mtree/BSD.tests.dist
| sbin/ping/tests/in_cksum_test.c | ||
|---|---|---|
| 89 ↗ | (On Diff #61041) | This doesn't guarantee that the array will be unaligned. It merely doesn't guarantee that it will be aligned. Better to declare an array that's aligned, then compute the checksum starting from the second byte. That way you'll know it's unaligned. |
Comment Actions
Add an entry to etc/mtree/BSD.tests.dist.
Ensure an unaligned data by starting from the second byte of an aligned data buffer.
| sbin/ping/tests/in_cksum_test.c | ||
|---|---|---|
| 89 ↗ | (On Diff #61041) | Thanks. It has been fixed. |
| sbin/ping/tests/in_cksum_test.c | ||
|---|---|---|
| 93 ↗ | (On Diff #61053) | But now the second argument is wrong. Shouldn't it be nitems(data) - 1? |
| sbin/ping/tests/in_cksum_test.c | ||
|---|---|---|
| 93 ↗ | (On Diff #61053) | You're right. Thanks. I'm editing too many diffs at once. |
| sbin/ping/tests/Makefile | ||
|---|---|---|
| 6 ↗ | (On Diff #61054) | Here's a footgun you didn't know about: WARNS is by default set to 6 for libraries and binaries, but 0 for tests. You need to set it explicitly. |
| sbin/ping/tests/Makefile | ||
|---|---|---|
| 6 ↗ | (On Diff #61054) | Fixed. |