Differential D21318

periodic: replace "tty" with "test -t 0"
ClosedPublic
Actions

Authored by asomers on Aug 18 2019, 5:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 4:35 AM

	Unknown Object (File)
	Sun, Oct 12, 12:39 AM

	Unknown Object (File)
	Mon, Oct 6, 6:08 AM

	Unknown Object (File)
	Mon, Sep 29, 8:42 PM

	Unknown Object (File)
	Sun, Sep 28, 11:39 PM

	Unknown Object (File)
	Thu, Sep 25, 11:31 AM

	Unknown Object (File)
	Sun, Sep 21, 2:09 AM

	Unknown Object (File)
	Tue, Sep 16, 9:36 PM

Subscribers

None

Details

Reviewers

imp
cy

Commits

rS352588: MF stable/12 r352489
rS352490: MFC r351192, r351203
rS352489: MFC r351192, r351203
rS351203: periodic: replace "tty" with "test -t 0"

Summary

periodic: replace "tty" with "test -t 0"

Apparently using tty for this purpose has been deprecated since 4.4 Lite.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Aug 18 2019, 5:24 PM

Harbormaster completed remote builds in B25947: Diff 60971.Aug 18 2019, 5:24 PM

cy requested changes to this revision.Aug 18 2019, 6:41 PM

cy added inline comments.

usr.sbin/periodic/periodic.sh
87 ↗	(On Diff #60971)	can this be if [ -t 0] ? test fork()s and exec()s a new process whereas [ performs the test within the shell, saving a fork() & exec().

This revision now requires changes to proceed.Aug 18 2019, 6:41 PM

Use [ instead of test

Harbormaster completed remote builds in B25949: Diff 60975.Aug 18 2019, 8:44 PM

Thanks. LGTM.

usr.sbin/periodic/periodic.sh
89 ↗	(On Diff #60975)	Sorry for missing this before but there is nothing between this else end endif. Did you mean export PERIODIC_IS_INTERACTIVE=0 or unset PERIODIC_IS_INTERACTIVE

asomers added inline comments.Aug 18 2019, 11:49 PM

usr.sbin/periodic/periodic.sh
89 ↗	(On Diff #60975)	Oh, crap, I meant to delete that. It was only there for debugging purposes.

Remove debugging detritus

Harbormaster completed remote builds in B25950: Diff 60980.Aug 18 2019, 11:49 PM

LGTM

This revision is now accepted and ready to land.Aug 19 2019, 1:09 AM

Closed by commit rS351203: periodic: replace "tty" with "test -t 0" (authored by asomers). · Explain WhyAug 19 2019, 1:14 AM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS351203: periodic: replace "tty" with "test -t 0".

asomers added a commit: rS352489: MFC r351192, r351203.Sep 18 2019, 5:18 PM

asomers added a commit: rS352490: MFC r351192, r351203.Sep 18 2019, 5:21 PM

asomers added a commit: rS352588: MF stable/12 r352489.Sep 22 2019, 12:13 AM

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

periodic/

2 lines

Diff 60984

head/usr.sbin/periodic/periodic.sh

Loading...