Page MenuHomeFreeBSD

Fix netdump buffering.
ClosedPublic

Authored by markj on Aug 16 2019, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 4:33 PM
Unknown Object (File)
Sat, Nov 29, 10:14 PM
Unknown Object (File)
Thu, Nov 27, 6:09 PM
Unknown Object (File)
Thu, Nov 27, 4:48 AM
Unknown Object (File)
Thu, Nov 20, 4:45 PM
Unknown Object (File)
Thu, Nov 20, 4:45 PM
Unknown Object (File)
Thu, Nov 20, 4:45 PM
Unknown Object (File)
Thu, Nov 20, 4:38 PM
Subscribers

Details

Summary

r348473 didn't take into account the fact that we use nd_buf for
buffering kernel dump and EKCD headers. This is done before the final
call to netdump_dumper(), which flushes residual data, so we were
clobbering that data. Add a netdump_flush_buf() function to flush
residual data and use it before copying headers into the buffer.

Test Plan

I never noticed this when debugging dumps from a netdump-enabled
syzkaller setup, but it manifested when I enabled zstd compression:
the decompressor would report corruption.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable