Page MenuHomeFreeBSD

Fix netdump buffering.
ClosedPublic

Authored by markj on Aug 16 2019, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 24, 1:39 AM
Unknown Object (File)
Mon, Mar 23, 9:07 PM
Unknown Object (File)
Sat, Mar 21, 8:12 PM
Unknown Object (File)
Fri, Mar 13, 4:30 AM
Unknown Object (File)
Sun, Mar 1, 4:06 PM
Unknown Object (File)
Sun, Mar 1, 1:25 PM
Unknown Object (File)
Sun, Mar 1, 11:08 AM
Unknown Object (File)
Jan 30 2026, 5:17 PM
Subscribers

Details

Summary

r348473 didn't take into account the fact that we use nd_buf for
buffering kernel dump and EKCD headers. This is done before the final
call to netdump_dumper(), which flushes residual data, so we were
clobbering that data. Add a netdump_flush_buf() function to flush
residual data and use it before copying headers into the buffer.

Test Plan

I never noticed this when debugging dumps from a netdump-enabled
syzkaller setup, but it manifested when I enabled zstd compression:
the decompressor would report corruption.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable