Page MenuHomeFreeBSD

graphics/photoflow: fix build on GCC architectures, don't optimize for builder CPU
ClosedPublic

Authored by pkubaj on Aug 16 2019, 1:53 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pkubaj created this revision.Aug 16 2019, 1:53 AM
mat added inline comments.Aug 19 2019, 12:03 PM
graphics/photoflow/Makefile
33 ↗(On Diff #60865)

What does this do exactly?

pkubaj added inline comments.Aug 19 2019, 11:31 PM
graphics/photoflow/Makefile
33 ↗(On Diff #60865)

Without this enabled, some staticly linked dependencies are optimized by default to the host CPU.

Since it's fine to do it when installing manually from the ports tree, I only disable it when using Poudriere.

mat added inline comments.Tue, Aug 20, 10:28 AM
graphics/photoflow/Makefile
33 ↗(On Diff #60865)

Then please add a comment saying so.

pkubaj updated this revision to Diff 61242.Sat, Aug 24, 7:29 PM
pkubaj marked an inline comment as done.

Add a comment with explanation.

linimon accepted this revision.Tue, Aug 27, 10:13 PM
This revision is now accepted and ready to land.Tue, Aug 27, 10:13 PM