Page MenuHomeFreeBSD

new port: security/py-xkcdpass
Needs RevisionPublic

Authored by jacob_jwfh.ca on Mon, Aug 12, 6:47 PM.

Details

Reviewers
0mp
Group Reviewers
Contributor Reviewers (ports)
Summary

Add port for XKCDPass, a password generator modelled after XKCD #936

WWW: https://github.com/jwfh/xkcdpass

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jacob_jwfh.ca created this revision.Mon, Aug 12, 6:47 PM

Modified security/Makefile to include the new port before py-xmlsec.

Previously the new port was not added in alphabetical order.

0mp requested changes to this revision.Tue, Aug 13, 9:03 AM
0mp added a subscriber: 0mp.

Thanks for submission. There are a couple of issues with the current patch, however.

security/py-xkcdpass/Makefile
11

It would be nice to set LICENSE_FILE

17

This is the default.

18

We could use ${DISTVERSION} here.

20

Is this necessary?

security/py-xkcdpass/pkg-descr
4

Missing WWW.

security/py-xkcdpass/pkg-plist
22

This is invalid. Use make makeplist to generate it properly.

This revision now requires changes to proceed.Tue, Aug 13, 9:03 AM
0mp added inline comments.Tue, Aug 13, 9:04 AM
security/py-xkcdpass/Makefile
13

Also, upstream README suggests that Python 2.7 and 3.4<= are supported.

https://github.com/redacted/XKCD-password-generator