Page MenuHomeFreeBSD

loader.efi: efipart should be more careful about constructing block device lists
ClosedPublic

Authored by tsoome on Thu, Aug 8, 3:55 PM.

Details

Summary

The cd handles should be collected as list of partitions. Some systems also provide base name for block device (like PciRoot(0x0)/Pci(0x5,0x0)), we need to be careful about those.

To make out life a bit easier, we prepare not just an array of handles, but we allocate pdinfo struct for each handle and devicepath, then we can simplify our work to sort the devices.

Test Plan

Tested with vmware fusion and bhyve.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tsoome created this revision.Thu, Aug 8, 3:55 PM
tsoome updated this revision to Diff 61036.Tue, Aug 20, 11:34 AM

review suggestions from illumos.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.