Page MenuHomeFreeBSD

Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME
ClosedPublic

Authored by tobik on Jul 30 2019, 3:21 PM.
Tags
None
Referenced Files
F81930111: D21114.diff
Tue, Apr 23, 8:46 AM
Unknown Object (File)
Sat, Apr 20, 3:43 PM
Unknown Object (File)
Feb 19 2024, 6:19 AM
Unknown Object (File)
Feb 19 2024, 6:19 AM
Unknown Object (File)
Feb 19 2024, 6:19 AM
Unknown Object (File)
Feb 19 2024, 12:53 AM
Unknown Object (File)
Feb 6 2024, 1:43 AM
Unknown Object (File)
Jan 20 2024, 12:26 PM
Subscribers

Details

Reviewers
dmgk
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP507751: Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME
Summary

It is often too general and can produce bad results with make makeplist. For example, in mail/aerc it produces bogus entries like

man/man5/%%GO_PKGNAME%%-sendmail.5.gz

since GO_PKGNAME=aerc there. AFAICT this was only ever really useful for Go libraries, so I think we should drop it now.

Only 2 ports appear to use it currently which are easily fixed.

Test Plan

I have done no real testing so far. This might affect more ports. I will start some Poudriere test builds after we agree that this is the right thing to do.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25595
Build 24195: arc lint + arc unit

Event Timeline

I'm traveling right now and cannot test this but it LGTM, thanks.

Thanks.

Tests builds were fine.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 6:25 AM
This revision was automatically updated to reflect the committed changes.