Page MenuHomeFreeBSD
Differential D21114

Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME
ClosedPublic
Actions

Authored by tobik on Jul 30 2019, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 8:46 AM
Unknown Object (File)
Sat, Apr 20, 3:43 PM
Unknown Object (File)
Feb 19 2024, 6:19 AM
Unknown Object (File)
Feb 19 2024, 6:19 AM
Unknown Object (File)
Feb 19 2024, 6:19 AM
Unknown Object (File)
Feb 19 2024, 12:53 AM
Unknown Object (File)
Feb 6 2024, 1:43 AM
Unknown Object (File)
Jan 20 2024, 12:26 PM
View All 29 Files
Subscribers
mat

Details

Reviewers
dmgk
Group Reviewers
O5: Ports Framework
portmgr
Commits
rP507751: Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME
Summary

It is often too general and can produce bad results with make makeplist. For example, in mail/aerc it produces bogus entries like

man/man5/%%GO_PKGNAME%%-sendmail.5.gz

since GO_PKGNAME=aerc there. AFAICT this was only ever really useful for Go libraries, so I think we should drop it now.

Only 2 ports appear to use it currently which are easily fixed.

Test Plan

I have done no real testing so far. This might affect more ports. I will start some Poudriere test builds after we agree that this is the right thing to do.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobik created this revision.Jul 30 2019, 3:21 PM
Owners added a reviewer: O5: Ports Framework.Jul 30 2019, 3:21 PM
Herald added a reviewer: portmgr. · View Herald TranscriptJul 30 2019, 3:21 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B25595: Diff 60287.Jul 30 2019, 3:21 PM
dmgk accepted this revision.Jul 31 2019, 2:36 PM

I'm traveling right now and cannot test this but it LGTM, thanks.

tobik added a comment.Aug 1 2019, 6:24 AM

Thanks.

Tests builds were fine.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 6:25 AM
Closed by commit rP507751: Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rP507751: Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
Uses/
1 lineO5: Ports Framework
databases/
go-carbon/
8 lines
security/
ct-submit/
2 lines
1 line

Diff 60350

View Options

head/Mk/Uses/go.mk

Loading...
View Options

head/databases/go-carbon/pkg-plist

Loading...
View Options

head/security/ct-submit/Makefile

Loading...
View Options

head/security/ct-submit/pkg-plist

Loading...