Page MenuHomeFreeBSD

Mk/Uses/go.mk: Drop PLIST_SUB for GO_PKGNAME
ClosedPublic

Authored by tobik on Jul 30 2019, 3:21 PM.

Details

Summary

It is often too general and can produce bad results with make makeplist. For example, in mail/aerc it produces bogus entries like

man/man5/%%GO_PKGNAME%%-sendmail.5.gz

since GO_PKGNAME=aerc there. AFAICT this was only ever really useful for Go libraries, so I think we should drop it now.

Only 2 ports appear to use it currently which are easily fixed.

Test Plan

I have done no real testing so far. This might affect more ports. I will start some Poudriere test builds after we agree that this is the right thing to do.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I'm traveling right now and cannot test this but it LGTM, thanks.

Thanks.

Tests builds were fine.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2019, 6:25 AM
This revision was automatically updated to reflect the committed changes.