Page MenuHomeFreeBSD

science/rdkit: fix build on GCC architectures
ClosedPublic

Authored by pkubaj on Jul 19 2019, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 4:10 AM
Unknown Object (File)
Sun, Oct 12, 3:57 PM
Unknown Object (File)
Fri, Sep 26, 8:04 AM
Unknown Object (File)
Fri, Sep 26, 7:27 AM
Unknown Object (File)
Thu, Sep 25, 9:15 PM
Unknown Object (File)
Thu, Sep 25, 1:30 PM
Unknown Object (File)
Wed, Sep 24, 3:44 AM
Unknown Object (File)
Wed, Sep 24, 2:10 AM
Subscribers
None

Details

Summary

This port needs new GCC to build.

It also adds -mpopcnt to *FLAGS, which breaks build on non-x86. Since it optimizes for the host CPU, don't enable it.

PR: 239299

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

science/rdkit/pkg-plist
298 ↗(On Diff #60293)

wouldn't it make more sense to use NON_PPC64 here? as you are not installing them when the architecture is ppc64.

science/rdkit/Makefile
52–56 ↗(On Diff #60293)

ARCH is defined after bsd.port.options.mk, no need to do the pre/post thing.

pkubaj marked an inline comment as done.

Don't include bsd.port.pre.mk, bsd.port.options.mk is enough.

Also the .if is not exclusive to powerpc64, but to all big-endian architectures. Since there's no ports variable for endianness, we need to list all architectures.

pkubaj added inline comments.
science/rdkit/pkg-plist
298 ↗(On Diff #60293)

Changed to LE, since the issue is about endianness.

"LE" is pretty generic, LITTLE_ENDIAN would probably be better.

This revision is now accepted and ready to land.Aug 19 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.