Page MenuHomeFreeBSD

science/rdkit: fix build on GCC architectures
ClosedPublic

Authored by pkubaj on Jul 19 2019, 4:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 23 2024, 4:50 AM
Unknown Object (File)
Feb 23 2024, 4:50 AM
Unknown Object (File)
Feb 23 2024, 4:50 AM
Unknown Object (File)
Feb 23 2024, 4:50 AM
Unknown Object (File)
Feb 23 2024, 4:50 AM
Unknown Object (File)
Feb 23 2024, 4:50 AM
Unknown Object (File)
Feb 22 2024, 5:05 PM
Unknown Object (File)
Jan 15 2024, 9:02 PM
Subscribers
None

Details

Summary

This port needs new GCC to build.

It also adds -mpopcnt to *FLAGS, which breaks build on non-x86. Since it optimizes for the host CPU, don't enable it.

PR: 239299

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25597
Build 24197: arc lint + arc unit

Event Timeline

science/rdkit/pkg-plist
298

wouldn't it make more sense to use NON_PPC64 here? as you are not installing them when the architecture is ppc64.

science/rdkit/Makefile
52–56

ARCH is defined after bsd.port.options.mk, no need to do the pre/post thing.

pkubaj marked an inline comment as done.

Don't include bsd.port.pre.mk, bsd.port.options.mk is enough.

Also the .if is not exclusive to powerpc64, but to all big-endian architectures. Since there's no ports variable for endianness, we need to list all architectures.

pkubaj added inline comments.
science/rdkit/pkg-plist
298

Changed to LE, since the issue is about endianness.

"LE" is pretty generic, LITTLE_ENDIAN would probably be better.

This revision is now accepted and ready to land.Aug 19 2019, 11:52 AM
This revision was automatically updated to reflect the committed changes.