[NEW PORT] devel/elm-format: Elm source code formatter
ClosedPublic
Actions

Authored by github_evilham.com on Jul 15 2019, 2:27 PM.

Details

Reviewers

arrowd

Commits

rP506817: devel/elm-format: New port. A tool for formatting programs written in Elm…

Summary

Between this port and lang/elm (bugzilla #236805) it is now easy to develop
using Elm under FreeBSD.
devel/elm-format itself does not compile, it only ensures consistent coding
standards following the official Elm Style Guide.

Test Plan

This port was compiled under poudriere without network access and tested on
multiple example Elm repositories.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25361
Build 24014: arc lint + arc unit

Event Timeline

github_evilham.com created this revision.Jul 15 2019, 2:27 PM

Herald added a subscriber: mat. · View Herald TranscriptJul 15 2019, 2:27 PM

Harbormaster completed remote builds in B25352: Diff 59764.Jul 15 2019, 2:27 PM

arrowd added inline comments.Jul 15 2019, 2:57 PM

devel/elm-format/Makefile
2	Add # $FreeBSD$ line at the very beginning of the Makefile.
4	No need for that.
5	I'd set `CATEGORIES= devel textproc`.
devel/elm-format/files/patch-Setup.hs
9	This would output `${PORTVERSION}` verbatim, not the real port version. Is this intended?

Built and ran manual tests again.

Harbormaster completed remote builds in B25353: Diff 59778.Jul 15 2019, 6:00 PM

github_evilham.com added inline comments.Jul 15 2019, 6:02 PM

devel/elm-format/files/patch-Setup.hs
9	I actually removed the dependency upon the produced file, so output is not relevant; didn't quite manage to remove dependency on this file, so I turned it into a no-op. Changed to `["0.8.1"]` instead as that's clearer and matches what the git command would spit.