Page MenuHomeFreeBSD

[NEW PORT] devel/elm-format: Elm source code formatter
ClosedPublic

Authored by github_evilham.com on Jul 15 2019, 2:27 PM.

Details

Summary

Between this port and lang/elm (bugzilla #236805) it is now easy to develop
using Elm under FreeBSD.
devel/elm-format itself does not compile, it only ensures consistent coding
standards following the official Elm Style Guide.

Test Plan

This port was compiled under poudriere without network access and tested on
multiple example Elm repositories.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arrowd added inline comments.Jul 15 2019, 2:57 PM
devel/elm-format/Makefile
1 ↗(On Diff #59764)

Add

# $FreeBSD$

line at the very beginning of the Makefile.

3 ↗(On Diff #59764)

No need for that.

4 ↗(On Diff #59764)

I'd set CATEGORIES= devel textproc.

devel/elm-format/files/patch-Setup.hs
8 ↗(On Diff #59764)

This would output ${PORTVERSION} verbatim, not the real port version. Is this intended?

github_evilham.com marked 4 inline comments as done.

Built and ran manual tests again.

devel/elm-format/files/patch-Setup.hs
8 ↗(On Diff #59764)

I actually removed the dependency upon the produced file, so output is not relevant; didn't quite manage to remove dependency on this file, so I turned it into a no-op.
Changed to ["0.8.1"] instead as that's clearer and matches what the git command would spit.

Rephrased pkg-descr so it's easier to parse by humans :-).

This revision was not accepted when it landed; it landed in state Needs Review.Jul 17 2019, 7:13 PM
This revision was automatically updated to reflect the committed changes.