Page MenuHomeFreeBSD

Use keyword to simplify ldconfig code
ClosedPublic

Authored by bapt on Jul 15 2019, 8:27 AM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

It allows INSTALL_AS_USER to work at the package level

Keywords/ldconfig.ucl
8 ↗(On Diff #59755)
if [ -z "${INSTALL_AS_USER}" ]
9 ↗(On Diff #59755)

Are there other exit codes for ldconfig ?

bapt added inline comments.
Keywords/ldconfig.ucl
9 ↗(On Diff #59755)

Not that I am aware of

This revision is now accepted and ready to land.Jul 15 2019, 12:46 PM

Properly test empty variable

This revision now requires review to proceed.Jul 15 2019, 12:49 PM
Keywords/ldconfig-linux.ucl
8–9 ↗(On Diff #59758)

Could this be written as:

%@/sbin/ldconfig

?

Avoid intermediary variable

bapt marked an inline comment as done.Jul 15 2019, 1:01 PM
bapt added inline comments.
Keywords/ldconfig-linux.ucl
8–9 ↗(On Diff #59758)

yes done

Keywords/ldconfig-linux.ucl
7 ↗(On Diff #59759)

Use $() instead of ``

bapt marked an inline comment as done.

Address latest @mat concerned

bapt marked an inline comment as done.Jul 15 2019, 1:20 PM
This revision is now accepted and ready to land.Jul 15 2019, 2:12 PM
This revision now requires review to proceed.Jul 15 2019, 2:13 PM

has this been committed ? or forgotten ?

I am still waiting for a review ;)

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 12:46 PM
This revision was automatically updated to reflect the committed changes.