Page MenuHomeFreeBSD
Differential D20951

Use keyword to simplify ldconfig code
ClosedPublic
Actions

Authored by bapt on Jul 15 2019, 8:27 AM.

Details

Reviewers
bapt
mat
Group Reviewers
portmgr
Commits
rP509644: Use keywords to simplify ldconfig code

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bapt created this revision.Jul 15 2019, 8:27 AM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptJul 15 2019, 8:27 AM
Herald added a subscriber: mat. · View Herald Transcript
bapt updated this revision to Diff 59751.Jul 15 2019, 8:36 AM

Fix ldconfig-linux

bapt added a comment.Jul 15 2019, 8:41 AM

It allows INSTALL_AS_USER to work at the package level

bapt updated this revision to Diff 59755.Jul 15 2019, 8:42 AM

Remove GNUism

mat added inline comments.Jul 15 2019, 12:07 PM
Keywords/ldconfig.ucl
8 ↗(On Diff #59755)
if [ -z "${INSTALL_AS_USER}" ]
9 ↗(On Diff #59755)

Are there other exit codes for ldconfig ?

bapt accepted this revision.Jul 15 2019, 12:46 PM
bapt added inline comments.
Keywords/ldconfig.ucl
9 ↗(On Diff #59755)

Not that I am aware of

This revision is now accepted and ready to land.Jul 15 2019, 12:46 PM
bapt updated this revision to Diff 59758.Jul 15 2019, 12:49 PM

Properly test empty variable

This revision now requires review to proceed.Jul 15 2019, 12:49 PM
bapt marked 2 inline comments as done.Jul 15 2019, 12:49 PM
mat added inline comments.Jul 15 2019, 12:58 PM
Keywords/ldconfig-linux.ucl
8–9 ↗(On Diff #59758)

Could this be written as:

%@/sbin/ldconfig

?

bapt updated this revision to Diff 59759.Jul 15 2019, 1:00 PM

Avoid intermediary variable

bapt marked an inline comment as done.Jul 15 2019, 1:01 PM
bapt added inline comments.
Keywords/ldconfig-linux.ucl
8–9 ↗(On Diff #59758)

yes done

mat added inline comments.Jul 15 2019, 1:19 PM
Keywords/ldconfig-linux.ucl
7 ↗(On Diff #59759)

Use $() instead of ``

bapt updated this revision to Diff 59761.Jul 15 2019, 1:20 PM
bapt marked an inline comment as done.

Address latest @mat concerned

bapt marked an inline comment as done.Jul 15 2019, 1:20 PM
mat accepted this revision.Jul 15 2019, 2:12 PM
This revision is now accepted and ready to land.Jul 15 2019, 2:12 PM
bapt updated this revision to Diff 59763.Jul 15 2019, 2:13 PM

Fix typo

This revision now requires review to proceed.Jul 15 2019, 2:13 PM
mat added a comment.Aug 13 2019, 1:12 PM

has this been committed ? or forgotten ?

bapt added a comment.Aug 22 2019, 11:00 AM

I am still waiting for a review ;)

mat added a comment.Aug 23 2019, 10:02 AM

Well, it looks ok to me.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 23 2019, 12:46 PM
Closed by commit rP509644: Use keywords to simplify ldconfig code (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rP509644: Use keywords to simplify ldconfig code.

Revision Contents
Changeset List

Diff 61154

View Options

head/Keywords/ldconfig-linux.ucl

Loading...
View Options

head/Keywords/ldconfig.ucl

Loading...
View Options

head/Mk/bsd.port.mk

Loading...