Add flowid to siftr(4)

[hiren]

Summary

Adding connection flowid as one of the fields to siftr(4).

[lstewart]

Minor typo needs fixing.

sys/netinet/siftr.c

491 ↗

(On Diff #4265)

s/pkg/pkt ?

541 ↗

(On Diff #4265)

Ditto

[hiren]

Bah, this is what happens when you develop/test on one system and generate review from other with all the phps that phabric needs.

I am sorry, I should have been more careful. Updating the diffs in a bit.

[hiren]

Updating with lstewart's typo catch.

[lstewart]

Looks good, although you might want to document in the man page any caveats related to when the flow id might be 0 (I can't remember if there are any situations in which the flow id is not set?)

[hiren]

In D2089#11, @lstewart wrote:

Looks good, although you might want to document in the man page any caveats related to when the flow id might be 0 (I can't remember if there are any situations in which the flow id is not set?)

Hum. Yeah, 0 could be a valid flowid or the default value when its not being set, afaik. I can add that to the manpage if that's what you prefer.

[lstewart]

I didn't think 0 was a valid flow id, in which case I think it would be useful to document the cases in which a consumer of SIFTR data might legitimately expect to see a flowid of 0 (if it's even possible - it might be that a flowid is always set in which case you don't need to document anything).

[hiren]

In D2089#15, @lstewart wrote:

I didn't think 0 was a valid flow id, in which case I think it would be useful to document the cases in which a consumer of SIFTR data might legitimately expect to see a flowid of 0

igb for example uses plain cpu /msix/queue id as flowid in which case 0 is a valid flowid.

(if it's even possible - it might be that a flowid is always set in which case you don't need to document anything).

I just looked at what adrian did for netstat -R. On my laptop with a single queue em(4), all I am getting is 0 as flowid with netstat -R. And em(4) is not setting flowid at all in the drivers. So, in this case its a default value.

[hiren]

Update manpage with the caveat about flowid '0'.

[hiren]

Closed by commit rS280233 (authored by @hiren).