Differential D20845

Remove a goto from vm_map_wire_locked
ClosedPublic
Actions

Authored by dougm on Jul 3 2019, 9:19 PM.

Tags

None

Referenced Files

	F153990951: D20845.diff
	Sat, Apr 25, 7:20 AM

	Unknown Object (File)
	Wed, Apr 22, 12:44 PM

	Unknown Object (File)
	Sat, Apr 11, 11:34 PM

	Unknown Object (File)
	Thu, Apr 9, 7:06 PM

	Unknown Object (File)
	Thu, Apr 9, 6:30 PM

	Unknown Object (File)
	Sat, Mar 28, 6:32 AM

	Unknown Object (File)
	Mar 24 2026, 8:48 PM

	Unknown Object (File)
	Mar 24 2026, 12:56 PM

View All 86 Files

Subscribers

imp

Details

Reviewers

alc

Commits

rS349713: Eliminate a goto and a label in vm_map_wire_locked by inserting an 'else'.

Summary

Removing the goto and its target label, and inserting an 'else' in front of the next 'if' to achieve the same control flow. produced no change in the number of machine instructions or their order on an amd64.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jul 3 2019, 9:19 PM

alc accepted this revision.Jul 3 2019, 10:35 PM

This revision is now accepted and ready to land.Jul 3 2019, 10:35 PM

Closed by commit rS349713: Eliminate a goto and a label in vm_map_wire_locked by inserting an 'else'. (authored by dougm). · Explain WhyJul 3 2019, 10:42 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS349713: Eliminate a goto and a label in vm_map_wire_locked by inserting an 'else'..

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2019, 10:42 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_map.c

5 lines

Diff 59375

View Options

Remove a goto from vm_map_wire_lockedClosedPublicActions