Differential D2083

sfxge: FreeBSD before 10 does not have bus_space_*_8 on amd64
ClosedPublic
Actions

Authored by arybchik on Mar 17 2015, 9:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 3, 10:42 AM

	Unknown Object (File)
	Thu, Sep 3, 10:38 AM

	Unknown Object (File)
	Wed, Sep 2, 11:08 PM

	Unknown Object (File)
	Sat, Aug 29, 1:11 AM

	Unknown Object (File)
	Sun, Aug 23, 2:04 AM

	Unknown Object (File)
	Mon, Aug 10, 9:39 AM

	Unknown Object (File)
	Mon, Aug 10, 7:19 AM

	Unknown Object (File)
	Jul 25 2026, 9:10 PM

View All Files

Subscribers

imp

network

Details

Reviewers

gnn

Commits

rS280378: sfxge: FreeBSD before 10 does not have bus_space_*_8 on amd64

Summary

bus_space_*_8() are not always macros, so it is not correct to use
#ifndef.

Sponsored by: Solarflare Communications, Inc.

Test Plan

Build tested on amd64.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

arybchik updated this revision to Diff 4250.Mar 17 2015, 9:01 AM

arybchik retitled this revision from to sfxge: FreeBSD before 10 does not have bus_space_*_8 on amd64.

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added a reviewer: gnn.

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2015, 9:01 AM

arybchik added a subscriber: network.Mar 17 2015, 9:02 AM

Closed by commit rS280378 (authored by @arybchik).

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

efsys.h

15 lines

Diff 4352

View Options

head/sys/dev/sfxge/common/efsys.h

sfxge: FreeBSD before 10 does not have bus_space_*_8 on amd64ClosedPublicActions