Differential D20823

multimedia/oggvideotools: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on Jul 1 2019, 11:56 AM.

Details

Reviewers

linimon
mat
tcberner

Commits

rP505953: multimedia/oggvideotools: fix build with GCC-based architectures

Summary

decoderTest.cpp needs include <cstring> for memset().

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25178
Build 23866: arc lint + arc unit

Event Timeline

pkubaj created this revision.Jul 1 2019, 11:56 AM

Harbormaster completed remote builds in B25151: Diff 59257.Jul 1 2019, 11:56 AM

mat added inline comments.Jul 1 2019, 7:24 PM

multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
16–18	this hunk is not needed.

pkubaj marked an inline comment as done.Jul 1 2019, 8:25 PM

pkubaj added inline comments.

multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
16–18	Hm, strange. I removed this hunk from the patch and it's clearly not in the file, but Phabricator somehow adds it.

Remove unnecessary hunk.

Harbormaster completed remote builds in B25178: Diff 59308.Jul 2 2019, 8:05 AM

pkubaj added inline comments.Jul 2 2019, 8:06 AM

multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
16–18	It's ok now, I accidentally submitted a new review instead of updating this one.

mat accepted this revision.Jul 5 2019, 4:49 PM

This revision is now accepted and ready to land.Jul 5 2019, 4:49 PM

Closed by commit rP505953: multimedia/oggvideotools: fix build with GCC-based architectures (authored by pkubaj). · Explain WhyJul 6 2019, 1:15 AM

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rP505953: multimedia/oggvideotools: fix build with GCC-based architectures.

Revision Contents
Changeset List

Path

Size

multimedia/

oggvideotools/

Makefile

2 lines

files/

patch-src_base_test_decoderTest.cpp

10 lines

Diff 59308

View Options

multimedia/oggvideotools/Makefile