Page MenuHomeFreeBSD
Differential D20823

multimedia/oggvideotools: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on Jul 1 2019, 11:56 AM.
Tags
None
Referenced Files
F157851801: D20823.id59458.diff
Mon, May 25, 8:28 PM
F157847603: D20823.id59308.diff
Mon, May 25, 7:52 PM
F157838923: D20823.id59257.diff
Mon, May 25, 6:21 PM
Unknown Object (File)
Sun, May 24, 11:52 PM
Unknown Object (File)
Sun, May 24, 11:47 PM
Unknown Object (File)
Sun, May 24, 11:31 AM
Unknown Object (File)
Wed, May 20, 1:14 AM
Unknown Object (File)
Mon, May 4, 7:31 PM
View All Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP505953: multimedia/oggvideotools: fix build with GCC-based architectures
Summary

decoderTest.cpp needs include <cstring> for memset().

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Jul 1 2019, 11:56 AM
Harbormaster completed remote builds in B25151: Diff 59257.Jul 1 2019, 11:56 AM
mat added inline comments.Jul 1 2019, 7:24 PM
multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
15–17 ↗(On Diff #59257)

this hunk is not needed.

pkubaj marked an inline comment as done.Jul 1 2019, 8:25 PM
pkubaj added inline comments.
multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
15–17 ↗(On Diff #59257)

Hm, strange. I removed this hunk from the patch and it's clearly not in the file, but Phabricator somehow adds it.

pkubaj updated this revision to Diff 59308.Jul 2 2019, 8:05 AM

Remove unnecessary hunk.

Harbormaster completed remote builds in B25178: Diff 59308.Jul 2 2019, 8:05 AM
pkubaj added inline comments.Jul 2 2019, 8:06 AM
multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
15–17 ↗(On Diff #59257)

It's ok now, I accidentally submitted a new review instead of updating this one.

mat accepted this revision.Jul 5 2019, 4:49 PM
This revision is now accepted and ready to land.Jul 5 2019, 4:49 PM
Closed by commit rP505953: multimedia/oggvideotools: fix build with GCC-based architectures (authored by pkubaj). · Explain WhyJul 6 2019, 1:15 AM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP505953: multimedia/oggvideotools: fix build with GCC-based architectures.

Revision Contents
Changeset List

PathSize
head/
multimedia/
oggvideotools/
2 lines
files/
10 lines

Diff 59458

View Options

head/multimedia/oggvideotools/Makefile

Loading...
View Options

head/multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp

Loading...