Page MenuHomeFreeBSD
Differential D20823

multimedia/oggvideotools: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on Jul 1 2019, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 17, 10:30 PM
Unknown Object (File)
Jul 28 2025, 10:33 AM
Unknown Object (File)
Jun 30 2025, 4:05 PM
Unknown Object (File)
Jun 29 2025, 3:12 PM
Unknown Object (File)
Jun 25 2025, 12:52 PM
Unknown Object (File)
Jun 20 2025, 1:20 AM
Unknown Object (File)
Jun 18 2025, 7:41 AM
Unknown Object (File)
Jun 17 2025, 1:29 PM
View All 67 Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP505953: multimedia/oggvideotools: fix build with GCC-based architectures
Summary

decoderTest.cpp needs include <cstring> for memset().

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pkubaj created this revision.Jul 1 2019, 11:56 AM
Harbormaster completed remote builds in B25151: Diff 59257.Jul 1 2019, 11:56 AM
mat added inline comments.Jul 1 2019, 7:24 PM
multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
15–17 ↗(On Diff #59257)

this hunk is not needed.

pkubaj marked an inline comment as done.Jul 1 2019, 8:25 PM
pkubaj added inline comments.
multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
15–17 ↗(On Diff #59257)

Hm, strange. I removed this hunk from the patch and it's clearly not in the file, but Phabricator somehow adds it.

pkubaj updated this revision to Diff 59308.Jul 2 2019, 8:05 AM

Remove unnecessary hunk.

Harbormaster completed remote builds in B25178: Diff 59308.Jul 2 2019, 8:05 AM
pkubaj added inline comments.Jul 2 2019, 8:06 AM
multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp
15–17 ↗(On Diff #59257)

It's ok now, I accidentally submitted a new review instead of updating this one.

mat accepted this revision.Jul 5 2019, 4:49 PM
This revision is now accepted and ready to land.Jul 5 2019, 4:49 PM
Closed by commit rP505953: multimedia/oggvideotools: fix build with GCC-based architectures (authored by pkubaj). · Explain WhyJul 6 2019, 1:15 AM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP505953: multimedia/oggvideotools: fix build with GCC-based architectures.

Revision Contents
Changeset List

PathSize
head/
multimedia/
oggvideotools/
2 lines
files/
10 lines

Diff 59458

View Options

head/multimedia/oggvideotools/Makefile

Loading...
View Options

head/multimedia/oggvideotools/files/patch-src_base_test_decoderTest.cpp

Loading...