Page MenuHomeFreeBSD

Clean up final QT4 leftovers
ClosedPublic

Authored by rene on Jun 23 2019, 4:20 PM.

Details

Summary

Clean up final QT4 leftovers after QT4 got removed from the ports tree last March.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner added inline comments.
Mk/bsd.sanity.mk
198 ↗(On Diff #58914)

^ shouldn't it stay here, as it became even more unsupported after being deleted ^^

multimedia/libmediaart/Makefile
29 ↗(On Diff #58914)

^ this seems like an unneeded change

Mk/bsd.sanity.mk
198 ↗(On Diff #58914)

Hmm, perhaps that's right. We might want to alert users a bit longer, but eventually this should go IMO.

multimedia/libmediaart/Makefile
29 ↗(On Diff #58914)

Why? qt4 is not a valid choice anymore, right?

multimedia/libmediaart/Makefile
29 ↗(On Diff #58914)

Because that is simply the line from the meson build file:

https://github.com/GNOME/libmediaart/blob/master/meson_options.txt

Revert change to multimedia/libmediaart/Makefile

multimedia/libmediaart/Makefile
29 ↗(On Diff #58914)

Fair enough ;)

Hm, this diff is wrong, it includes local changes :(

The sanity bits need to stay, we don't remove them.

Mk/bsd.sanity.mk
282 ↗(On Diff #58947)

Though this is wrong, it should say something like "QT5 as QT4 is not here any more."

rene marked 2 inline comments as done.Jun 24 2019, 8:04 PM

if make index passes, it's ok by me.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 28 2019, 10:34 PM
This revision was automatically updated to reflect the committed changes.