Page MenuHomeFreeBSD

Cleanup patching of static content with sed.

Authored by mat on Jun 17 2019, 8:58 PM.

Diff Detail

rD FreeBSD doc repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat created this revision.Jun 17 2019, 8:58 PM
adamw added a subscriber: adamw.Jun 17 2019, 9:01 PM
adamw added inline comments.
7600 ↗(On Diff #58749)

This version has ${PREFIX}, but the one above has ${LOCALBASE}.

422 ↗(On Diff #58749)

This should be a semicolon, not a comma.

mat marked an inline comment as done.Jun 20 2019, 10:56 AM
mat added inline comments.
422 ↗(On Diff #58749)

This seems off:

Do not use it to replace static content; use patch files for that.

For me, semicolon is used to separate two non related clauses, which could be separate sentences. Here, the two clauses are related and the second emphasizes the first.

mat updated this revision to Diff 58829.Jun 20 2019, 10:57 AM
  • Be consistent.
adamw added inline comments.Jun 20 2019, 12:22 PM
422 ↗(On Diff #58749)

The problem is that with a comma, one of the clauses must be dependent (i.e. a non-complete sentence). Here, both clauses are complete sentences, making it what's called a "comma splice."

I fully agree that the semicolon is weird there. Perhaps "You must use patch files instead of sed to replace static content." Or something like that.

mat marked 2 inline comments as done.Jun 20 2019, 2:36 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 20 2019, 2:36 PM
This revision was automatically updated to reflect the committed changes.