Page MenuHomeFreeBSD
Differential D20420

Add modevent_nop: NOP module event handler
AbandonedPublic
Actions

Authored by cem on May 27 2019, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 8:28 AM
Unknown Object (File)
Sun, Oct 12, 4:23 PM
Unknown Object (File)
Sun, Oct 12, 4:15 PM
Unknown Object (File)
Sun, Oct 12, 1:25 PM
Unknown Object (File)
Sun, Oct 12, 9:26 AM
Unknown Object (File)
Sun, Oct 12, 6:38 AM
Unknown Object (File)
Thu, Sep 25, 11:33 AM
Unknown Object (File)
Sun, Sep 21, 12:01 AM
View All 76 Files
Subscribers
None

Details

Reviewers
jhb
markj
Summary

The default NULL eventhandler forbids unload.

For modules that would like to allow unload, but don't care about module
events, the function "modevent_nop" is exposed. This should allow some
deduplication of identical modevent handler implementations.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24548
Build 23334: arc lint + arc unit

Event Timeline

cem created this revision.May 27 2019, 1:53 AM
Harbormaster completed remote builds in B24526: Diff 57932.May 27 2019, 1:53 AM
markj accepted this revision.May 27 2019, 6:44 PM

It'd be nice to document this in MODULE(9) or so.

This revision is now accepted and ready to land.May 27 2019, 6:44 PM
cem updated this revision to Diff 57975.May 27 2019, 10:35 PM
  • Document in module.9
This revision now requires review to proceed.May 27 2019, 10:35 PM
Harbormaster completed remote builds in B24548: Diff 57975.May 27 2019, 10:35 PM
jhb requested changes to this revision.May 28 2019, 5:08 PM

See my comments in the other review. markj was just wrong about DRIVER_MODULE. I don't think this is needed.

This revision now requires changes to proceed.May 28 2019, 5:08 PM
cem mentioned this in D20407: virtio(4): Add PNP match metadata for virtio devices.May 28 2019, 5:20 PM
cem abandoned this revision.May 28 2019, 5:26 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
25 lines
sys/
kern/
24 lines
sys/
7 lines

Diff 57975

View Options

share/man/man9/module.9

Loading...
View Options

sys/kern/kern_module.c

Loading...
View Options

sys/sys/module.h

Loading...