Differential D20377

Remove "struct ucred*" argument from vtruncbuf
ClosedPublic
Actions

Authored by asomers on May 23 2019, 2:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 1, 12:56 AM

	Unknown Object (File)
	Oct 24 2023, 11:54 PM

	Unknown Object (File)
	Aug 28 2023, 4:30 AM

	Unknown Object (File)
	Aug 28 2023, 4:27 AM

	Unknown Object (File)
	Aug 28 2023, 4:27 AM

	Unknown Object (File)
	Aug 28 2023, 4:18 AM

	Unknown Object (File)
	Aug 26 2023, 2:17 PM

	Unknown Object (File)
	Jul 1 2023, 3:23 PM

View All 14 Files

Subscribers

Details

Reviewers

Commits

rS349308: MFC r348251:
rS349305: MFC r348251:
rS348251: Remove "struct ucred*" argument from vtruncbuf

Summary

Remove "struct ucred*" argument from vtruncbuf

vtruncbuf takes a "struct ucred*" argument. AFAICT, it's been unused ever
since that function was first added in r34611. Remove it.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.May 23 2019, 2:03 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 23 2019, 2:03 PM

Harbormaster completed remote builds in B24426: Diff 57764.May 23 2019, 2:03 PM

LGTM, thanks!

sys/fs/fuse/fuse_io.c
392 ↗	(On Diff #57764)	I'd structure this as two separate commits, vtruncbuf first, fuse second; or at least update the commit message to reflect that FUSE was also changed in a similar fashion.
466 ↗	(On Diff #57764)	Might as well fix the line wrapping whitespace while you're here? Not a big deal. Ditto below.
sys/fs/nfsclient/nfs_clbio.c
1835 ↗	(On Diff #57764)	Ditto the comment in FUSE: I'd structure this as another independent commit, but if not, please mention it in the commit message as well.

This revision is now accepted and ready to land.May 23 2019, 4:24 PM

asomers added inline comments.May 23 2019, 4:27 PM

sys/fs/nfsclient/nfs_clbio.c
1835 ↗	(On Diff #57764)	Ok, I'll mention it in the commit message. I don't want to separate it into two commits, because that would create more unused arguments in ncl_meta_setsize and fuse_vnode_setsize.

cem added inline comments.May 23 2019, 4:35 PM

sys/fs/nfsclient/nfs_clbio.c
1835 ↗	(On Diff #57764)	Briefly, yes, but then the followup commit(s) would remove those. Doing it all in one is totally reasonable, too.

Closed by commit rS348251: Remove "struct ucred*" argument from vtruncbuf (authored by asomers). · Explain WhyMay 24 2019, 8:28 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS349305: MFC r348251:.Jun 23 2019, 1:35 PM

asomers added a commit: rS349308: MFC r348251:.Jun 23 2019, 2:49 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

fs/

ext2fs/

4 lines

fuse/

6 lines

2 lines

4 lines

6 lines

msdosfs/

msdosfs_denode.c

2 lines

nfsclient/

3 lines

4 lines

3 lines

kern/

6 lines

sys/

3 lines

ufs/

ffs/

2 lines

Diff 57857

head/sys/fs/ext2fs/ext2_inode.c

Loading...

head/sys/fs/fuse/fuse_io.c

Loading...

head/sys/fs/fuse/fuse_node.h

Loading...

head/sys/fs/fuse/fuse_node.c

Loading...

head/sys/fs/fuse/fuse_vnops.c

Loading...

head/sys/fs/msdosfs/msdosfs_denode.c

Loading...

head/sys/fs/nfsclient/nfs.h

Loading...

head/sys/fs/nfsclient/nfs_clbio.c

Loading...

head/sys/fs/nfsclient/nfs_clvnops.c

Loading...

head/sys/kern/vfs_subr.c

Loading...

head/sys/sys/vnode.h

Loading...

head/sys/ufs/ffs/ffs_inode.c

Loading...