Page MenuHomeFreeBSD

Allow additional flags to be passed to netstat -i in the daily status check.
ClosedPublic

Authored by jhb on Mar 9 2015, 2:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 14, 3:23 PM
Unknown Object (File)
Tue, May 14, 10:48 AM
Unknown Object (File)
Wed, May 8, 10:38 PM
Unknown Object (File)
Fri, Apr 26, 7:20 AM
Unknown Object (File)
Fri, Apr 26, 7:20 AM
Unknown Object (File)
Mar 12 2024, 6:27 AM
Unknown Object (File)
Jan 24 2024, 1:20 AM
Unknown Object (File)
Jan 21 2024, 3:09 PM
Subscribers

Details

Reviewers
bz
Summary

Allow additional flags to be passed to netstat -i in the daily status check.
In particular, this allows an administrator to specify "-h" for human
readable output if that is preferred.

Arguably "-d" should be moved into the default value of this flag so that
administrators can disable it if desired.

Submitted by: Lystopad Aleksandr <laa@laa.zp.ua>

Test Plan
  • haven't tested yet

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jhb retitled this revision from to Allow additional flags to be passed to netstat -i in the daily status check..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
bz requested changes to this revision.Mar 12 2015, 4:42 PM
bz edited edge metadata.
bz added inline comments.
etc/defaults/periodic.conf
93

is this unrelated whitespace change?

etc/periodic/daily/420.status-network
24โ€“26

These ;; need to go now, right? They are moved to after the netstat call in the next line

share/man/man5/periodic.conf.5
28

.Dd needs update on commit

This revision now requires changes to proceed.Mar 12 2015, 4:42 PM

Also, since I committed the patch to add "-d", I'm going to change this to move "-d" into the default value of this variable. (And I will test this on my laptop before I upload the next version)

etc/defaults/periodic.conf
93

Yes. I could split it out if you want me to.

etc/periodic/daily/420.status-network
24โ€“26

Oh, yes.

share/man/man5/periodic.conf.5
28

Of course, I'm not optimistic enough to add the date when I upload to manpage diffs. :)

jhb edited edge metadata.
  • Move 'd' into the default flags value.
  • Fix syntax error (script is tested now).
  • Note default values in periodic.conf(5).
bz edited edge metadata.

Sorry for the delay. Go ahead!

etc/defaults/periodic.conf
92

Yes, please split it out. otherwise it's confusing. No need for a different review though :-)

share/man/man5/periodic.conf.5
28

Please update on commit.

This revision is now accepted and ready to land.Mar 26 2015, 5:41 PM