Page MenuHomeFreeBSD

devel/thrift-cpp: fix build with GCC-based architectures
ClosedPublic

Authored by pkubaj on May 17 2019, 10:54 AM.

Details

Summary

Add -L${OPENSSLLIB} -I${OPENSSLINC} only when base OpenSSL isn't used. Explicitly adding -L/usr/lib make ports GCC link to libstdc++ from /usr/lib instead of /usr/local/lib/gcc8.

Also, explicitly don't use Lua and Qt5, the port uses it if it's installed.

PR: 237506

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pkubaj created this revision.May 17 2019, 10:54 AM
tcberner added inline comments.May 17 2019, 6:53 PM
devel/thrift-cpp/Makefile
47 ↗(On Diff #57478)

^I'd say this warrants a PORTREVISON bump

pkubaj updated this revision to Diff 57498.May 17 2019, 7:26 PM

Bump PORTREVISION.

mat accepted this revision.May 20 2019, 12:36 PM

Looks ok, pending maintainer's approval.

This revision is now accepted and ready to land.May 20 2019, 12:36 PM
This revision was automatically updated to reflect the committed changes.

Committed because maintainer timeout.