Differential D20285

textproc/topic: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on May 17 2019, 10:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 24, 1:33 PM

	Unknown Object (File)
	Tue, Nov 18, 8:41 PM

	Unknown Object (File)
	Tue, Nov 18, 2:20 PM

	Unknown Object (File)
	Sat, Nov 15, 8:35 AM

	Unknown Object (File)
	Mon, Nov 10, 3:22 AM

	Unknown Object (File)
	Mon, Nov 10, 12:54 AM

	Unknown Object (File)
	Wed, Nov 5, 5:48 AM

	Unknown Object (File)
	Sat, Nov 1, 6:49 AM

View All 79 Files

Subscribers

None

Details

Reviewers

linimon
mat
tcberner

Commits

rP502123: textproc/topic: fix build with GCC-based architectures

Summary

Remove -Werror to fix this:
./linenoise.c: In function 'linenoiseEdit':
./linenoise.c:765: warning: comparison is always false due to limited range of data type

With -Werror, it causes a build error on GCC architectures.

PR: 237555

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkubaj created this revision.May 17 2019, 10:49 AM

Harbormaster completed remote builds in B24276: Diff 57476.May 17 2019, 10:49 AM

Not quite sure if that makes sense. Won't the compiled binary basically do garbage in this case?

Add specific signed to the variable. This solves the build issue.

Harbormaster completed remote builds in B24290: Diff 57500.May 17 2019, 7:50 PM

mat accepted this revision.May 20 2019, 12:37 PM

This revision is now accepted and ready to land.May 20 2019, 12:37 PM

Closed by commit rP502123: textproc/topic: fix build with GCC-based architectures (authored by pkubaj). · Explain WhyMay 20 2019, 4:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

textproc/

topic/

Makefile

2 lines

files/

patch-linenoise.c

11 lines

Diff 57585

View Options

head/textproc/topic/Makefile