Page MenuHomeFreeBSD

textproc/topic: fix build with GCC-based architectures
ClosedPublic

Authored by pkubaj on May 17 2019, 10:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 22, 7:39 AM
Unknown Object (File)
Apr 28 2026, 5:26 AM
Unknown Object (File)
Apr 27 2026, 11:42 AM
Unknown Object (File)
Apr 27 2026, 8:08 AM
Unknown Object (File)
Apr 26 2026, 5:21 AM
Unknown Object (File)
Apr 25 2026, 8:26 PM
Unknown Object (File)
Apr 19 2026, 11:12 AM
Unknown Object (File)
Apr 15 2026, 11:06 AM
Subscribers
None

Details

Summary

Remove -Werror to fix this:
./linenoise.c: In function 'linenoiseEdit':
./linenoise.c:765: warning: comparison is always false due to limited range of data type

With -Werror, it causes a build error on GCC architectures.

PR: 237555

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Not quite sure if that makes sense. Won't the compiled binary basically do garbage in this case?

Add specific signed to the variable. This solves the build issue.

This revision is now accepted and ready to land.May 20 2019, 12:37 PM
This revision was automatically updated to reflect the committed changes.