Page MenuHomeFreeBSD

textproc/topic: fix build with GCC-based architectures
ClosedPublic

Authored by pkubaj on May 17 2019, 10:49 AM.

Details

Summary

Remove -Werror to fix this:
./linenoise.c: In function 'linenoiseEdit':
./linenoise.c:765: warning: comparison is always false due to limited range of data type

With -Werror, it causes a build error on GCC architectures.

PR: 237555

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pkubaj created this revision.May 17 2019, 10:49 AM

Not quite sure if that makes sense. Won't the compiled binary basically do garbage in this case?

pkubaj updated this revision to Diff 57500.May 17 2019, 7:50 PM

Add specific signed to the variable. This solves the build issue.

mat accepted this revision.May 20 2019, 12:37 PM
This revision is now accepted and ready to land.May 20 2019, 12:37 PM
This revision was automatically updated to reflect the committed changes.