Paths

Table of Contentst

Differential D20277

revert 4GB workarounds for bge and aac
ClosedPublic
Actions

Authored by tychon on May 16 2019, 1:16 PM.

Tags

None

Referenced Files

	F166408380: D20277.diff
	Thu, Aug 13, 11:21 AM

	Unknown Object (File)
	Wed, Aug 12, 12:22 AM

	Unknown Object (File)
	Fri, Aug 7, 4:22 PM

	Unknown Object (File)
	Tue, Aug 4, 3:02 PM

	Unknown Object (File)
	Sun, Aug 2, 3:50 AM

	Unknown Object (File)
	Sun, Aug 2, 12:43 AM

	Unknown Object (File)
	Sat, Aug 1, 7:20 AM

	Unknown Object (File)
	Sat, Jul 25, 6:24 PM

Subscribers

Details

Reviewers

kib
jhb

Commits

rS347890: reinstate 4GB DMA boundary workarounds for bge and aac

Summary

After r346386, DMA transactions may again cross 4GB boundaries. I had intended to return the per-device workaround for devices known to have 64-bit issues. Apparently while I got the header file component I missed the salient change to bge in the shuffle. Also add the necessary workaround for aac.

This is a straightforward revert of r232766 and r232260 respectively.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tychon created this revision.May 16 2019, 1:16 PM

kib added inline comments.May 16 2019, 7:52 PM

sys/dev/aac/aac_pci.c
447 ↗	(On Diff #57445)	aac uses BUS_SPACE_MAXSIZE_32BIT in other places.

tychon added inline comments.May 16 2019, 8:10 PM

sys/dev/aac/aac_pci.c
447 ↗	(On Diff #57445)	Yeah, I see that but `BUS_SPACE_MAXSIZE_32BIT` (`0xFFFFFFFF`) isn't a power-of-2. Isn't that a requirement for alignment?

kib accepted this revision.May 16 2019, 8:26 PM

kib added inline comments.

sys/dev/aac/aac_pci.c
447 ↗	(On Diff #57445)	I see.

This revision is now accepted and ready to land.May 16 2019, 8:26 PM

Closed by commit rS347890: reinstate 4GB DMA boundary workarounds for bge and aac (authored by tychon). · Explain WhyMay 16 2019, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 16 2019, 8:41 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

aac/

3 lines

bge/

37 lines

6 lines

Diff 57461

head/sys/dev/aac/aac_pci.c

Loading...

head/sys/dev/bge/if_bge.c

Loading...

head/sys/dev/bge/if_bgereg.h

Loading...