Differential D20186

Add simple regression tests for tree(3).
ClosedPublic
Actions

Authored by trasz on May 7 2019, 5:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 10 2025, 1:32 AM

	Unknown Object (File)
	Jan 6 2025, 8:02 PM

	Unknown Object (File)
	Dec 16 2024, 9:42 PM

	Unknown Object (File)
	Nov 22 2024, 7:07 AM

	Unknown Object (File)
	Nov 22 2024, 7:06 AM

	Unknown Object (File)
	Nov 22 2024, 7:06 AM

	Unknown Object (File)
	Nov 22 2024, 6:45 AM

	Unknown Object (File)
	Oct 4 2024, 11:26 PM

View All 56 Files

Subscribers

Details

Reviewers

Commits

rS347425: Add simple regression tests for tree(3). Those are ATF-ified versions

Summary

Add simple regression tests for tree(3). Those are ATF-ified versions
of OpenBSD's regress/sys/sys/tree/.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.May 7 2019, 5:56 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 7 2019, 5:56 PM

Harbormaster completed remote builds in B24137: Diff 57141.May 7 2019, 5:56 PM

seemslegit

tests/sys/sys/splay_test.c
68–94 ↗	(On Diff #57141)	General comment (I know this is upstream code): testing against ITER/ITER-1 (because the splay is removed on 92) is ok, but it is a bit fragile in the event that more code is added in the middle of the two loops. It would be better to increment the maximum value, decrement when removing, then test against the new smaller maximum in the second loop.
71–74 ↗	(On Diff #57141)	That's an interesting way to handle collisions...

This revision is now accepted and ready to land.May 8 2019, 11:31 PM

Closed by commit rS347425: Add simple regression tests for tree(3). Those are ATF-ified versions (authored by trasz). · Explain WhyMay 10 2019, 7:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

tests/

sys/

sys/

2 lines

108 lines

108 lines

Diff 57250

head/tests/sys/sys/Makefile

Loading...

head/tests/sys/sys/rb_test.c

Loading...

head/tests/sys/sys/splay_test.c

Loading...