Page MenuHomeFreeBSD

fsx: seed more randomly with the -S0 option
ClosedPublic

Authored by asomers on Apr 26 2019, 8:05 PM.

Details

Summary

fsx: seed more randomly with the -S0 option

When using -S0, seed the PRNG with the current time in nanoseconds, not
seconds, so consecutive runs don't accidentally use the same seed.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Apr 26 2019, 8:05 PM
ngie accepted this revision.Apr 28 2019, 5:09 PM

This change is very reasonable.

FWIW, I wish there was a standard upstream source for fsx. A number of different OSes have their own version of fsx with their own set of bugs.

tools/regression/fsx/fsx.c
278–280 ↗(On Diff #56727)

Thought: I think this could be better done in terms of actual intermediate variables, instead of a comment, for clarity.

This revision is now accepted and ready to land.Apr 28 2019, 5:09 PM
asomers updated this revision to Diff 56786.Apr 28 2019, 5:14 PM

Respond to ngie's suggestions

This revision now requires review to proceed.Apr 28 2019, 5:14 PM
This revision is now accepted and ready to land.Apr 28 2019, 5:24 PM
This revision was automatically updated to reflect the committed changes.