Differential D20078

fsx: seed more randomly with the -S0 option
ClosedPublic
Actions

Authored by asomers on Apr 26 2019, 8:05 PM.

Details

Reviewers

ngie

Commits

rS348465: MFC r346847:
rS347643: MFC r346847:
rS346847: fsx: seed more randomly with the -S0 option

Summary

fsx: seed more randomly with the -S0 option

When using -S0, seed the PRNG with the current time in nanoseconds, not
seconds, so consecutive runs don't accidentally use the same seed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Apr 26 2019, 8:05 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 26 2019, 8:05 PM

Harbormaster completed remote builds in B23943: Diff 56727.Apr 26 2019, 8:05 PM

This change is very reasonable.

FWIW, I wish there was a standard upstream source for fsx. A number of different OSes have their own version of fsx with their own set of bugs.

tools/regression/fsx/fsx.c
278–280 ↗	(On Diff #56727)	Thought: I think this could be better done in terms of actual intermediate variables, instead of a comment, for clarity.

This revision is now accepted and ready to land.Apr 28 2019, 5:09 PM

Respond to ngie's suggestions

This revision now requires review to proceed.Apr 28 2019, 5:14 PM

Harbormaster completed remote builds in B23963: Diff 56786.Apr 28 2019, 5:14 PM

thankyou_dog

This revision is now accepted and ready to land.Apr 28 2019, 5:24 PM

Closed by commit rS346847: fsx: seed more randomly with the -S0 option (authored by asomers). · Explain WhyApr 28 2019, 5:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

tools/

regression/

fsx/

fsx.c

37 lines

Diff 56787

View Options

head/tools/regression/fsx/fsx.c

fsx: seed more randomly with the -S0 optionClosedPublicActions