Differential D20074

ci-qemu-test.sh and make some improvements
ClosedPublic
Actions

Authored by bcran on Apr 26 2019, 2:26 PM.

Details

Reviewers

emaste
imp

Commits

rS346748: Fix tools/boot/ci-qemu-test.sh and make some improvements

Summary

Update ci-qemu-test.sh

Update the path to the OVMF file, which is now in /usr/local/share/uefi-edk2-qemu.
Use the more modern q35, pc-q35-3.0 (Q35 + ICH9, 2009) QEMU machine instead of the default, obsolete pc, pc-i440fx-3.0 (i440FX + PIIX, 1996). For example this adds ACPI support.
Specify the system firmware using the newer pflash drive syntax instead of bios.
Remove extra, unneeded devices by passing -nodefaults
Change text to talk about 'firmware' instead of 'bios', since UEFI isn't a BIOS.

Test Plan

Ran the script and verified it succeeded with QEMU 3.0.1 from emulators/qemu.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bcran created this revision.Apr 26 2019, 2:26 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 26 2019, 2:27 PM

Harbormaster completed remote builds in B23928: Diff 56707.Apr 26 2019, 2:27 PM

bcran retitled this revision from Update ci-qemu-test.sh - Update the path to the OVMF file, which is now in /usr/local/share/uefi-edk2-qemu. - Use the more modern q35, pc-q35-3.0 (Q35 + ICH9, 2009) QEMU machine instead of the default, obsolete pc, pc-i440fx-3.0 (i440FX + PIIX... to Fix tools/boot/ci-qemu-test.sh and make some improvements.Apr 26 2019, 2:29 PM

bcran edited the summary of this revision. (Show Details)

emaste accepted this revision.Apr 26 2019, 2:34 PM

This revision is now accepted and ready to land.Apr 26 2019, 2:34 PM

imp accepted this revision.Apr 26 2019, 2:36 PM

Closed by commit rS346748: Fix tools/boot/ci-qemu-test.sh and make some improvements (authored by bcran). · Explain WhyApr 26 2019, 2:44 PM

This revision was automatically updated to reflect the committed changes.