Page MenuHomeFreeBSD

Add emulators/fs-uae-devel port
Needs ReviewPublic

Authored by johalun on Apr 26 2019, 1:22 AM.

Details

Reviewers
imp
zeising
Summary

Add emulators/fs-uae-devel port. This requires variables in the master port
emulators/fs-uae to be overridden and that change is included in this patch.

Test Plan

Build tested poudriere.
Runtime tested on local laptop.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24370
Build 23190: arc lint + arc unit

Event Timeline

johalun created this revision.Apr 26 2019, 1:22 AM

In general, I'm not sure -devel ports are usually slave ports, slave ports are more often to have ports with different options, such as nox11 variants. You also need to check with the owner of the original port for approval, since you're touching that one. You also need do add CONFLICTS since I assume both ports can't be installed at the same time (installing things in the same place).

Had I done it, I'd probably done svn cp of fs-uae to fs-uae-devel and created a separate port.

emulators/fs-uae-devel/Makefile
7

Use your @f.o mail address. If you own other ports, those should probably be updated as well.

johalun updated this revision to Diff 56829.Apr 29 2019, 7:34 PM

Change from slave port to separate port.

mat added inline comments.Apr 30 2019, 3:41 PM
emulators/fs-uae-devel/Makefile
30

Default, remove.

31

Commit 3d6a8dc7a60ffe15a1878fd813f7d96fa432a41a is "2.9.7dev4", so this commit does not really represent the version number you are using here. I suggest either using a version of 2.9.7.gyyyymmdd of the commit, or only gyyyymmdd.

johalun updated this revision to Diff 56864.Apr 30 2019, 3:54 PM

Fix Makefile according to comments by reviewer.

johalun marked 3 inline comments as done.Apr 30 2019, 3:57 PM
johalun updated this revision to Diff 57647.May 21 2019, 9:09 PM

Update distinfo to fix error after changing version.

johalun updated this revision to Diff 57649.May 21 2019, 9:32 PM

Run portfmt

johalun updated this revision to Diff 57654.May 21 2019, 10:06 PM

Take ownership over fs-uae as per agreement with maintainer.

mat added inline comments.May 22 2019, 7:27 AM
emulators/fs-uae-devel/Makefile
10

I'd say that the fact that the port is named -devel is enough.

32

Can probably be written as:

CONFLICTS_INSTALL=      fs-uae
emulators/fs-uae/Makefile
15

Can probably be written as:

CONFLICTS_INSTALL=      fs-uae-devel