Page MenuHomeFreeBSD

netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl
ClosedPublic

Authored by cem on Apr 20 2019, 3:25 AM.
Tags
None
Referenced Files
F168177585: D19980.id.diff
Wed, Aug 26, 5:46 PM
F168154126: D19980.id56416.diff
Wed, Aug 26, 3:18 PM
F168142367: D19980.id56431.diff
Wed, Aug 26, 2:00 PM
F168129691: D19980.diff
Wed, Aug 26, 12:39 PM
Unknown Object (File)
Sun, Aug 16, 6:31 PM
Unknown Object (File)
Thu, Jul 30, 1:13 PM
Unknown Object (File)
Jul 27 2026, 12:00 AM
Unknown Object (File)
Jul 21 2026, 3:48 AM

Details

Summary

The logic was present for the 11 version of the DIOCSKERNELDUMP ioctl, but
had not been updated for the 12 ABI.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 20 2019, 10:38 AM
This revision was automatically updated to reflect the committed changes.

Now a kernel configuration without COMPAT_FREEBSD11 generates the following errror:

`--- netdump_client.o ---
/usr/src/sys/netinet/netdump/netdump_client.c:1143:8: error: unused variable 'u' [-Werror,-Wunused-variable]

u_int u;
      ^

1 error generated.
`

head/sys/netinet/netdump/netdump_client.c
1143

Use #ifdef COMPAT_FREEBSD11 here as well.

head/sys/netinet/netdump/netdump_client.c
1143

Thanks for the catch!

LGTM.
A kernel configuration without COMPAT_FREEBSD11 is building successfully again.

This revision is now accepted and ready to land.Apr 24 2019, 7:16 AM