Page MenuHomeFreeBSD

Some cleanups for the PF chapter in the handbook
ClosedPublic

Authored by bcr on Apr 17 2019, 5:33 PM.

Details

Summary

This patch does the following:

  1. Change the warning message to remove the reference to a specific PF version and point out that FreeBSDs pf has diverged from what's in OpenBSD.
  2. Remove a link to the old pf porting efforts, which are obsolete nowadays and don't provide much value to the reader anymore
  3. Change the flow in reading to put the ALTQ section at the end of the chapter. Most people don't use ALTQ with PF, so having that at the end of the chapter is good to not overwhelm the reader too much with concepts they probably don't need.
  4. Remove the "In order to" sentence parts which are mostly superfluous and can be replaced with "to" to increase readability
  5. Sprinkle in some sysrc in examples where it makes sense to use it
Test Plan

a) Apply patch to the firewall chapter of the handbook.
b) Run "make" in the handbook chapter.
c) Check firewalls-pf.html output.

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bcr created this revision.Apr 17 2019, 5:33 PM
kp added inline comments.Apr 18 2019, 10:29 AM
en_US.ISO8859-1/books/handbook/firewalls/chapter.xml
319 ↗(On Diff #56296)

"not all features work the same way on &os"

bcr updated this revision to Diff 56332.Apr 18 2019, 10:53 AM

Update with Kristof's comments.

bcr marked an inline comment as done.Apr 18 2019, 10:54 AM

Comments addressed.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 18 2019, 11:22 AM
This revision was automatically updated to reflect the committed changes.