Page MenuHomeFreeBSD

Factor out section loading into a separate function
ClosedPublic

Authored by trasz on Apr 8 2019, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 3 2024, 9:50 AM
Unknown Object (File)
Apr 19 2024, 12:57 AM
Unknown Object (File)
Apr 18 2024, 9:07 PM
Unknown Object (File)
Jan 18 2024, 5:05 AM
Unknown Object (File)
Dec 20 2023, 8:04 AM
Unknown Object (File)
Nov 27 2023, 7:42 PM
Unknown Object (File)
Sep 7 2023, 8:53 PM
Unknown Object (File)
Sep 7 2023, 8:53 PM
Subscribers

Details

Summary

Factor out section loading into a separate function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/kern/imgact_elf.c
680 ↗(On Diff #55944)

Indentation looks weird, this is because the block span is wrong. numsegs++ should be done regardless of != NULL.

Perhaps rename numsegs to e.g. first_loadable and change type to boolean.

After that, you can move assignment of zero to *base_addrp after the loop.

trasz marked an inline comment as done.Apr 9 2019, 2:34 PM
This revision is now accepted and ready to land.Apr 9 2019, 3:00 PM
This revision was automatically updated to reflect the committed changes.