Page MenuHomeFreeBSD

Factor out section loading into a separate function
ClosedPublic

Authored by trasz on Apr 8 2019, 3:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 8:59 AM
Unknown Object (File)
Sun, Oct 12, 5:54 PM
Unknown Object (File)
Sun, Oct 5, 2:19 AM
Unknown Object (File)
Sun, Sep 28, 11:09 AM
Unknown Object (File)
Thu, Sep 25, 7:20 PM
Unknown Object (File)
Thu, Sep 25, 8:41 AM
Unknown Object (File)
Sep 17 2025, 2:08 AM
Unknown Object (File)
Sep 16 2025, 11:52 PM
Subscribers

Details

Summary

Factor out section loading into a separate function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/kern/imgact_elf.c
680 ↗(On Diff #55944)

Indentation looks weird, this is because the block span is wrong. numsegs++ should be done regardless of != NULL.

Perhaps rename numsegs to e.g. first_loadable and change type to boolean.

After that, you can move assignment of zero to *base_addrp after the loop.

trasz marked an inline comment as done.Apr 9 2019, 2:34 PM
This revision is now accepted and ready to land.Apr 9 2019, 3:00 PM
This revision was automatically updated to reflect the committed changes.