Page MenuHomeFreeBSD

Factor out section loading into a separate function
ClosedPublic

Authored by trasz on Apr 8 2019, 3:11 PM.
Tags
None
Referenced Files
F145358879: D19846.id55996.diff
Wed, Feb 18, 6:33 PM
Unknown Object (File)
Tue, Feb 17, 12:48 PM
Unknown Object (File)
Mon, Feb 16, 12:43 PM
Unknown Object (File)
Mon, Feb 9, 11:04 AM
Unknown Object (File)
Dec 12 2025, 3:19 AM
Unknown Object (File)
Dec 11 2025, 3:15 AM
Unknown Object (File)
Nov 27 2025, 5:43 AM
Unknown Object (File)
Nov 24 2025, 10:48 AM
Subscribers

Details

Summary

Factor out section loading into a separate function.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/kern/imgact_elf.c
680 ↗(On Diff #55944)

Indentation looks weird, this is because the block span is wrong. numsegs++ should be done regardless of != NULL.

Perhaps rename numsegs to e.g. first_loadable and change type to boolean.

After that, you can move assignment of zero to *base_addrp after the loop.

trasz marked an inline comment as done.Apr 9 2019, 2:34 PM
This revision is now accepted and ready to land.Apr 9 2019, 3:00 PM
This revision was automatically updated to reflect the committed changes.