Differential D19846

Factor out section loading into a separate function
ClosedPublic
Actions

Authored by trasz on Apr 8 2019, 3:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 27, 5:43 AM

	Unknown Object (File)
	Mon, Nov 24, 10:48 AM

	Unknown Object (File)
	Mon, Nov 24, 1:19 AM

	Unknown Object (File)
	Sun, Nov 23, 6:53 AM

	Unknown Object (File)
	Sat, Nov 22, 6:15 PM

	Unknown Object (File)
	Fri, Nov 21, 11:11 AM

	Unknown Object (File)
	Tue, Nov 11, 5:37 PM

	Unknown Object (File)
	Mon, Nov 10, 3:55 AM

Subscribers

Details

Reviewers

Commits

rS346053: Factor out section loading into a separate function.

Summary

Factor out section loading into a separate function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Apr 8 2019, 3:11 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 8 2019, 3:11 PM

Harbormaster completed remote builds in B23567: Diff 55944.Apr 8 2019, 3:11 PM

kib added inline comments.Apr 8 2019, 3:55 PM

sys/kern/imgact_elf.c
680 ↗	(On Diff #55944)	Indentation looks weird, this is because the block span is wrong. numsegs++ should be done regardless of != NULL. Perhaps rename numsegs to e.g. first_loadable and change type to boolean. After that, you can move assignment of zero to *base_addrp after the loop.

Fixes from kib@.

Harbormaster completed remote builds in B23593: Diff 55996.Apr 9 2019, 2:33 PM

trasz marked an inline comment as done.Apr 9 2019, 2:34 PM

kib accepted this revision.Apr 9 2019, 3:00 PM

This revision is now accepted and ready to land.Apr 9 2019, 3:00 PM

Closed by commit rS346053: Factor out section loading into a separate function. (authored by trasz). · Explain WhyApr 9 2019, 3:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

116 lines

Diff 56000

head/sys/kern/imgact_elf.c

Loading...