for a cache-only zone the destructor tries to destroy a non-existent keg
ClosedPublic
Actions

Authored by tychon on Apr 5 2019, 11:55 PM.

Details

Reviewers

glebius
markj
jeff

Commits

rS346150: for a cache-only zone the destructor tries to destroy a non-existent keg

Summary

Pure cache zones have no kegs. However since uz_keg and uz_lockptr are shared members of struct uma_zone a pointer to a lock may masquerade as a pointer to a keg. Therefore it’s insufficient to test uz_keg to determine if a zone has a keg.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tychon created this revision.Apr 5 2019, 11:55 PM

tychon added a reviewer: glebius.

tychon added reviewers: markj, jeff.Apr 9 2019, 7:04 PM

markj added inline comments.Apr 11 2019, 8:08 AM

sys/vm/uma_core.c
1921 ↗	(On Diff #55868)	I believe you can test `(uz_flags & UMA_ZFLAG_CACHE) == 0` instead.

tychon mentioned this in D19845: to be compatible with an IOMMU LinuxKPI should use bus_dma(9).Apr 11 2019, 1:30 PM

Use markj@'s suggestion for a more overt/intuitive fix.

tychon marked an inline comment as done.Apr 11 2019, 1:45 PM

markj accepted this revision.Apr 11 2019, 5:16 PM

markj added inline comments.

sys/vm/uma_core.c
1922 ↗	(On Diff #56091)	These tests can be combined into one.

This revision is now accepted and ready to land.Apr 11 2019, 5:16 PM

Might a well make this as good as can be. I combined the tests into one.

This revision now requires review to proceed.Apr 12 2019, 11:01 AM

markj accepted this revision.Apr 12 2019, 11:57 AM

This revision is now accepted and ready to land.Apr 12 2019, 11:57 AM

Closed by commit rS346150: for a cache-only zone the destructor tries to destroy a non-existent keg (authored by tychon). · Explain WhyApr 12 2019, 12:46 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptApr 12 2019, 12:46 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

uma_core.c

6 lines

Diff 56133

View Options

for a cache-only zone the destructor tries to destroy a non-existent kegClosedPublicActions