Page MenuHomeFreeBSD

New port www/p5-RT-Extension-RepeatTicket
Needs ReviewPublic

Authored by matthew on Mar 30 2019, 2:09 PM.

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Requesting approval for adding a flavoured port

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23399
Build 22415: arc lint + arc unit

Event Timeline

matthew created this revision.Mar 30 2019, 2:09 PM
matthew edited the summary of this revision. (Show Details)Mar 30 2019, 2:09 PM
matthew added a reviewer: portmgr.
mat accepted this revision as: portmgr.Mar 31 2019, 12:49 PM
mat added inline comments.
www/p5-RT-Extension-RepeatTicket/Makefile
19–20

Lines should be in reverse order, FLAVORS first.

37

No need for += here.

matthew updated this revision to Diff 55656.Mar 31 2019, 7:33 PM

Address @mat's comments

matthew marked 2 inline comments as done.Mar 31 2019, 7:34 PM

Thanks very much for creating the port.

This extension normally requires running "make initdb" to create a custom field called Original Ticket. The port currently doesn't provide an easy way to do that, and I'm really not sure how it could do so elegantly. I managed to do so by running "make -n initdb" in the port wrkdir, then doing likewise on our production server where we'd installed the package:

XXXX:/usr/local/share/rt42/plugins/RT-Extension-RepeatTicket# /usr/local/bin/perl -Ilib -I/usr/local/share/rt42/lib -I/usr/local/lib/perl5/site_perl -I. /usr/local/sbin/rt-setup-database --action insert --datadir etc --datafile etc/initialdata --dba root --prompt-for-dba-password  --package RT::Extension::RepeatTicket --ext-version 1.11
In order to create or update your RT database, this script needs to connect to your  mysql instance on localhost (port '') as root
Please specify that user's database password below. If the user has no database
password, just press return.

Password: 
Working with:
Type:   mysql
Host:   localhost
Port:
Name:   XXXX
User:   XXXX
DBA:    root
Now inserting data.
Done inserting data.
Done.

Thanks very much for creating the port.
This extension normally requires running "make initdb" to create a custom field called Original Ticket. The port currently doesn't provide an easy way to do that, and I'm really not sure how it could do so elegantly. I managed to do so by running "make -n initdb" in the port wrkdir, then doing likewise on our production server where we'd installed the package:

I see. If there's any documentation that says that, it would seem to be fairly well hidden. I'll add a pkg-message to warn the users and see if I can include all the necessary files in the package.

Yeah, the requirement is mentioned in the documentation.

https://metacpan.org/pod/RT::Extension::RepeatTicket#make-initdb

Everything one needs is being packaged already; you just need to know exactly how to invoke /usr/local/sbin/rt-setup-database.