Page MenuHomeFreeBSD

Mk/Uses/php.mk: Flag invalid args
ClosedPublic

Authored by tobik on Mar 29 2019, 11:46 AM.

Details

Summary

Flag invalid USES=php arguments to avoid mistakes like

USES=		php:filter,gettext

instead of

USES=		php
USE_PHP=	filter gettext
Test Plan

Ran make -V IGNORE over the tree. The following ports had problems (I've already fixed them):

Origin						Invalid USES=php args			Fixed in
net-mgmt/nagiosql				filter gettext mysql session simplexml	rP497106
net-mgmt/glpi-plugins-fusioninventory-server	fileinfo (and simplexml, wddx [1])	rP497107

[1] Those are not flagged since USES=php is included multiple times.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Mar 29 2019, 11:46 AM
ale added inline comments.Mar 30 2019, 8:16 AM
Mk/Uses/php.mk
7 ↗(On Diff #55591)

I don't think "one of" is the correct wording, you can combine a few of them.

tobik updated this revision to Diff 55616.Mar 30 2019, 8:42 AM
tobik marked an inline comment as done.
  • Update "Valid ARGS" comment with missing components
ale accepted this revision.Mar 30 2019, 9:15 AM

LGTM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2019, 6:36 PM
This revision was automatically updated to reflect the committed changes.