Differential D1970

Fix comment in sched_balance_pair and check load before locking
Needs ReviewPublic
Actions

Authored by harrison-astrodog.net on Feb 26 2015, 12:03 PM.

Tags

None

Referenced Files

	F158974971: D1970.diff
	Mon, Jun 8, 12:13 PM

	Unknown Object (File)
	Tue, May 19, 1:26 AM

	Unknown Object (File)
	Tue, May 19, 1:24 AM

	Unknown Object (File)
	Mon, May 18, 6:03 AM

	Unknown Object (File)
	Sun, May 17, 4:16 PM

	Unknown Object (File)
	Thu, May 14, 10:51 PM

	Unknown Object (File)
	Thu, May 14, 10:51 PM

	Unknown Object (File)
	May 5 2026, 5:41 AM

Subscribers

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

harrison-astrodog.net updated this revision to Diff 3989.Feb 26 2015, 12:03 PM

harrison-astrodog.net retitled this revision from to Fix comment in sched_balance_pair and check load before locking.

harrison-astrodog.net updated this object.

harrison-astrodog.net edited the test plan for this revision. (Show Details)

koobs added a subscriber: koobs.Feb 26 2015, 2:29 PM

one nit

sys/kern/sched_ule.c
917	Does moving this outside the lock expose yourself to races because the memory barrier that's implicit in the lock doesn't happen?

emaste added a subscriber: emaste.Feb 26 2015, 5:15 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

sched_ule.c

16 lines

Diff 3989

View Options

Fix comment in sched_balance_pair and check load before lockingNeeds ReviewPublicActions