Page MenuHomeFreeBSD
Differential D1970

Fix comment in sched_balance_pair and check load before locking
Needs ReviewPublic
Actions

Authored by harrison-astrodog.net on Feb 26 2015, 12:03 PM.
Tags
None
Referenced Files
F168732022: D1970.diff
Sat, Aug 29, 9:01 PM
Unknown Object (File)
Thu, Aug 27, 7:14 PM
Unknown Object (File)
Thu, Aug 27, 3:50 PM
Unknown Object (File)
Tue, Aug 25, 3:30 PM
Unknown Object (File)
Tue, Aug 25, 8:05 AM
Unknown Object (File)
Tue, Aug 25, 7:24 AM
Unknown Object (File)
Tue, Aug 25, 6:56 AM
Unknown Object (File)
Sat, Aug 15, 9:09 AM
View All Files
Subscribers
emaste
imp
koobs
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

harrison-astrodog.net updated this revision to Diff 3989.Feb 26 2015, 12:03 PM
harrison-astrodog.net retitled this revision from to Fix comment in sched_balance_pair and check load before locking.
harrison-astrodog.net updated this object.
harrison-astrodog.net edited the test plan for this revision. (Show Details)
koobs added a subscriber: koobs.Feb 26 2015, 2:29 PM
imp added a subscriber: imp.Feb 26 2015, 4:00 PM

one nit

sys/kern/sched_ule.c
917

Does moving this outside the lock expose yourself to races because the memory barrier that's implicit in the lock doesn't happen?

emaste added a subscriber: emaste.Feb 26 2015, 5:15 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
16 lines

Diff 3989

View Options

sys/kern/sched_ule.c

Loading...