Differential D19696

Make smartpqi(4) behave better when running out of memory.
ClosedPublic
Actions

Authored by trasz on Mar 24 2019, 8:25 PM.

Details

Reviewers

sbruno
deepak.ukey_microsemi.com
imp

Commits

rS345549: Make smartpqi(4) behave better when running out of memory, by returning

Summary

Make smartpqi(4) behave better when running out of memory,
by returning CAM_RESRC_UNAVAIL instead of CAM_REQUEUE_REQ.
This makes CAM delay a bit before retrying, so that the
retries actually get a chance to succeed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Mar 24 2019, 8:25 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2019, 8:25 PM

Harbormaster completed remote builds in B23278: Diff 55413.Mar 24 2019, 8:25 PM

trasz added reviewers: sbruno, deepak.ukey_microsemi.com.Mar 24 2019, 8:26 PM

sbruno accepted this revision.Mar 24 2019, 9:06 PM

This revision is now accepted and ready to land.Mar 24 2019, 9:06 PM

I think this looks good, but I've not studied it in enough detail to know for sure.
It might make sense to see if Scott or Ken has a chance to look into this to be sure it's the right solution.

Closed by commit rS345549: Make smartpqi(4) behave better when running out of memory, by returning (authored by trasz). · Explain WhyMar 26 2019, 3:47 PM

This revision was automatically updated to reflect the committed changes.

Damn, committed it before reading the comments, sorry for that. Still, I've compared this with what isp(4), mpt(4) and iscsi(4) do (and actually done that in the past with iscsi(4)), so it should be all right.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

smartpqi/

smartpqi_cam.c

24 lines

Diff 55459

View Options

head/sys/dev/smartpqi/smartpqi_cam.c

Make smartpqi(4) behave better when running out of memory.ClosedPublicActions