Page MenuHomeFreeBSD

Make smartpqi(4) behave better when running out of memory.
ClosedPublic

Authored by trasz on Mar 24 2019, 8:25 PM.

Details

Summary

Make smartpqi(4) behave better when running out of memory,
by returning CAM_RESRC_UNAVAIL instead of CAM_REQUEUE_REQ.
This makes CAM delay a bit before retrying, so that the
retries actually get a chance to succeed.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

trasz created this revision.Mar 24 2019, 8:25 PM
sbruno accepted this revision.Mar 24 2019, 9:06 PM
This revision is now accepted and ready to land.Mar 24 2019, 9:06 PM
imp accepted this revision.Mar 26 2019, 3:58 AM

I think this looks good, but I've not studied it in enough detail to know for sure.
It might make sense to see if Scott or Ken has a chance to look into this to be sure it's the right solution.

This revision was automatically updated to reflect the committed changes.
trasz added a comment.Mar 26 2019, 3:48 PM

Damn, committed it before reading the comments, sorry for that. Still, I've compared this with what isp(4), mpt(4) and iscsi(4) do (and actually done that in the past with iscsi(4)), so it should be all right.