Page MenuHomeFreeBSD
Differential D19644

lang/erlang-runtime21: switch to GitHub build and update to 21.3.1.
ClosedPublic
Actions

Authored by olgeni on Mar 19 2019, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 2:29 PM
Unknown Object (File)
Sat, Apr 20, 2:44 PM
Unknown Object (File)
Jan 30 2024, 12:50 AM
Unknown Object (File)
Jan 30 2024, 12:50 AM
Unknown Object (File)
Jan 30 2024, 12:50 AM
Unknown Object (File)
Jan 30 2024, 12:50 AM
Unknown Object (File)
Jan 30 2024, 12:50 AM
Unknown Object (File)
Jan 30 2024, 12:31 AM
View All 35 Files
Subscribers
mat

Details

Reviewers
jrm
dch
Commits
rP498549: lang/erlang-runtime21: switch to GitHub build and update to 21.3.3.
Summary

A bit more work towards GitHub builds for Erlang, so that it becomes easier to update.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olgeni created this revision.Mar 19 2019, 2:20 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 19 2019, 2:20 PM
Harbormaster completed remote builds in B23176: Diff 55233.Mar 19 2019, 2:20 PM
Harbormaster completed remote builds in B23176: Diff 55233.
jrm added inline comments.Mar 19 2019, 3:37 PM
lang/erlang-runtime21/Makefile
6 ↗(On Diff #55233)

You could use DISTVERSION here to make portlint happy and conform to the Order of Variables in Port Makefiles as described in the Porter's Handbook.

9–11 ↗(On Diff #55233)

Does MASTER_SITES still need to be defined now that you have USE_GITHUB?

olgeni added inline comments.Mar 19 2019, 3:43 PM
lang/erlang-runtime21/Makefile
6 ↗(On Diff #55233)

Good catch - and I even had it right in the other runtime ports..

9–11 ↗(On Diff #55233)

Nope. Also, ERLANG_REL is unused now. Let me have a look.

olgeni updated this revision to Diff 55237.Mar 19 2019, 4:20 PM

Remove obsolete MASTER_SITES and ERLANG_REL.

Harbormaster completed remote builds in B23178: Diff 55237.Mar 19 2019, 4:20 PM
jrm added a comment.Mar 19 2019, 4:26 PM

It looks good to me, but I will let @dch approve, since he is more experienced with erlang.

olgeni updated this revision to Diff 55335.Mar 21 2019, 9:52 PM

21.3.2 is out. Upgrades are indeed more comfy :)

Harbormaster completed remote builds in B23238: Diff 55335.Mar 21 2019, 9:52 PM
dch accepted this revision.Mar 29 2019, 9:15 PM
This revision is now accepted and ready to land.Mar 29 2019, 9:15 PM
Closed by commit rP498549: lang/erlang-runtime21: switch to GitHub build and update to 21.3.3. (authored by olgeni). · Explain WhyApr 10 2019, 10:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lang/
erlang-runtime21/
54 lines
8 lines

Diff 56042

View Options

head/lang/erlang-runtime21/Makefile

Loading...
View Options

head/lang/erlang-runtime21/distinfo

Loading...