Page MenuHomeFreeBSD

graphics/py-PyX12: Downgrade to 0.12.1 and add missing dependency
AbandonedPublic

Authored by kai on Mar 8 2019, 7:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 22 2024, 6:01 PM
Unknown Object (File)
Jan 13 2024, 12:32 PM
Unknown Object (File)
Dec 20 2023, 6:27 AM
Unknown Object (File)
Nov 8 2023, 2:29 AM
Unknown Object (File)
Nov 8 2023, 2:00 AM
Unknown Object (File)
Nov 6 2023, 3:28 PM
Unknown Object (File)
Nov 6 2023, 2:26 AM
Unknown Object (File)
Nov 5 2023, 5:33 PM
Subscribers

Details

Summary

There are two ports in the ports tree:

  • graphics/py-PyX
  • graphics/py-PyX12

Both ports are nearly identical but 0.14.1 is not compatible with Python 2.7. This is the reason why graphics/py-PyX12 exists and it was repocopied from graphics/py-PyX in r357702.

Also add "dvipsk" as dependency when using the option KPATHSEA (that is on by default) to fix a runtime error when loading the dvi/mapfile.py submodule:

./dvips: No such file or directory
Assertion failed: (ret), function remove_dots, file progname.c, line 316.
Abort (core dumped)

Test Plan
  • poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r344874 amd64 + i386) -> OK (with options KPATHSEA/T1CODE enabled, disabled and mixed)
  • portlint -> OK
  • Runtime tests -> OK

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23108
Build 22163: arc lint + arc unit

Event Timeline

Created timestamp in distinfo by "make makesum". SHA-256 checksum did not change.

So why was PyX12 updated to 14.1 in the first place?

So why was PyX12 updated to 14.1 in the first place?

It might be a mistake. The commit log gives no exact explanation about that. In rP357702 there is the reason given why graphics/py-PyX12 was created in the first place.

According to:
https://www.freshports.org/graphics/py-PyX12/

nothing needs it, why not kill it ?

It's required for the PYX option (not enabled by default) of net/scapy. I came across it when I was working on the update for that port to 2.4.0 (PR #230110).

So why was PyX12 updated to 14.1 in the first place?

I think sunpoet did it by mistake. The logs specially r357702 is self explanatory about the problem

In D19510#417583, @kai wrote:

Created timestamp in distinfo by "make makesum". SHA-256 checksum did not change.

This is not the proper way to fix this problem. We can just svn merge to the previous revision.

Addressing bofh's suggestion by using svn merge.

In D19510#417583, @kai wrote:

Created timestamp in distinfo by "make makesum". SHA-256 checksum did not change.

This is not the proper way to fix this problem. We can just svn merge to the previous revision.

Thank you for the suggestion. The previous revisions have no TIMESTAMP value so far. I'm not sure if that will be a problem for the pre-commit hook when committing the changes?

In D19510#419481, @kai wrote:
In D19510#417583, @kai wrote:

Created timestamp in distinfo by "make makesum". SHA-256 checksum did not change.

This is not the proper way to fix this problem. We can just svn merge to the previous revision.

Thank you for the suggestion. The previous revisions have no TIMESTAMP value so far. I'm not sure if that will be a problem for the pre-commit hook when committing the changes?

Oops. In that case of I believe you can do a remote merge which will bypass the pre-commit hook.
% svn merge -r484640:484639 svn+ssh://bofh@repo.freebsd.org/ports/graphics/py-PyX12/Makefile
% svn merge -r484640:484639 svn+ssh://bofh@repo.freebsd.org/ports/graphics/py-PyX12/distinfo

graphics/py-PyX12 has been removed from the ports tree in rP497393 . It won't be required for net/scapy when it has been updated to 2.4.2 that will use Python 3 then.