subversion: update commit message template to allow URLs in PR field
AcceptedPublic
Actions

Authored by vangyzen on Mar 4 2019, 7:58 PM.

Details

Reviewers

Summary

Following D19426, suggest URLs in addition to PR numbers in the PR field.
Also suggest adding multiple PR lines, which will probably be even more
relevant with the much longer URLs.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22897
Build 21983: arc lint + arc unit

Event Timeline

vangyzen created this revision.Mar 4 2019, 7:58 PM

Herald added subscribers: dab, badger. · View Herald TranscriptMar 4 2019, 7:58 PM

Harbormaster completed remote builds in B22883: Diff 54705.Mar 4 2019, 7:58 PM

D19459 covers subversion in the base system.

vangyzen mentioned this in D19426: post-commit hooks: Accept BZ URLs in PR lines.Mar 4 2019, 8:01 PM

Just mention the URL in the comments.

Harbormaster completed remote builds in B22897: Diff 54736.Mar 5 2019, 7:07 PM

Close, very very close, but still slightly short of leaving no doubt as to what goes here.

devel/subversion/files/extra-patch-fbsd-template
126	id=nnnn or id=PRnnnn? It is unclear to me if it wants the PR or not, iirc the line for phabricator clearly has Dxxxx in it.

vangyzen added inline comments.Mar 5 2019, 7:32 PM

devel/subversion/files/extra-patch-fbsd-template
126	In my mind, `#` means "number". Besides, I imagine the vast majority of people will copy the URL directly from their browser, not copy this example and replace the `###`. I think it's fine as-is, and I'd rather not make the line any longer, since it's already more than 80 columns.