Page MenuHomeFreeBSD

Silence irrelevant warning on 32 bit platforms.
AbandonedPublic

Authored by bdragon on Feb 26 2019, 11:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 4:58 PM
Unknown Object (File)
Jan 31 2024, 7:08 PM
Unknown Object (File)
Dec 20 2023, 5:07 AM
Unknown Object (File)
Sep 27 2023, 8:48 PM
Unknown Object (File)
Aug 26 2023, 2:52 PM
Unknown Object (File)
Aug 7 2023, 7:45 AM
Unknown Object (File)
Jul 5 2023, 12:05 PM
Unknown Object (File)
May 14 2023, 6:27 PM
Subscribers

Details

Reviewers
jhibbits
Summary

In r309092, a warning was added to note when the PhysicalUpperBound register isn't implemented, to make it more obvious that remote debugging will only be able to access the first 4G of physical RAM.

However, on 32 bit platforms, we shouldn't even care in the first place, since the rest of the system can't address more than that either.

Removes an annoying warning I am experiencing when testing firewire on my iBook G4.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/dev/firewire/fwohci.c
1865

I think it'd be better to instead make it check on Maxmem, and only display the warning if ptoa(Maxmem) > 2**32. 32-bit platforms can have more than 4GB RAM, however unlikely that may be.

sys/dev/firewire/fwohci.c
1865

It's not unlikely at all. Many late i386 machines have 4GB of RAM, but part of that is mapped above the 4GB boundary.

jhibbits requested changes to this revision.May 3 2019, 8:22 PM

See above comment. It shouldn't be gated on LP64

This revision now requires changes to proceed.May 3 2019, 8:22 PM

Abandoning, after further thought, I'd really rather have it there so I know what the interface is capable of anyway.