Differential D19278

multimedia/syncplay: Update to 1.6.2
ClosedPublic
Actions

Authored by kai on Feb 20 2019, 11:57 PM.

Tags

None

Referenced Files

	F106705197: D19278.diff
	Sat, Jan 4, 3:22 AM

	Unknown Object (File)
	Wed, Dec 25, 2:49 AM

	Unknown Object (File)
	Sun, Dec 22, 6:21 AM

	Unknown Object (File)
	Mon, Dec 9, 3:55 PM

	Unknown Object (File)
	Nov 14 2024, 8:37 AM

	Unknown Object (File)
	Nov 12 2024, 11:16 PM

	Unknown Object (File)
	Nov 12 2024, 11:16 PM

	Unknown Object (File)
	Oct 28 2024, 11:11 PM

View All 83 Files

Subscribers

None

Details

Reviewers

miwi
tcberner
joneum

Commits

rP494151: multimedia/syncplay: Update to 1.6.2

Summary

PR 235790

While I'm here:

Sort variables a bit according to the PHB

Changelog:

Switched from Python 2 to Python 3
All changes since 1.5.5:

https://syncplay.pl/changelog/

Test Plan

poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r344112 amd64 + i386) with options CLIENT and/or SERVER enabled and GUI and/or VLC enabled -> OK
portlint -> OK (brings warnings about icon installation but this can be ignored because it's a Qt application that handles icons differently, AFAIK)
Runtime test -> OK

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22633
Build 21742: arc lint + arc unit

Event Timeline

kai created this revision.Feb 20 2019, 11:57 PM

Harbormaster completed remote builds in B22633: Diff 54168.Feb 20 2019, 11:57 PM

tcberner added inline comments.Feb 21 2019, 6:18 AM

multimedia/syncplay/Makefile
38	^ did you drop this intentionally?

tcberner added inline comments.Feb 21 2019, 6:20 AM

multimedia/syncplay/Makefile
38	ignore, I did not see it moved up

LGTM

This revision is now accepted and ready to land.Feb 28 2019, 11:40 AM

Closed by commit rP494151: multimedia/syncplay: Update to 1.6.2 (authored by kai). · Explain WhyFeb 28 2019, 1:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

multimedia/

syncplay/

14 lines

6 lines

files/

patch-GNUmakefile

8 lines

patch-syncplay_ui_GuiConfiguration.py

13 lines

Diff 54168

multimedia/syncplay/Makefile

Loading...

multimedia/syncplay/distinfo

Loading...

multimedia/syncplay/files/patch-GNUmakefile

Loading...

multimedia/syncplay/files/patch-syncplay_ui_GuiConfiguration.py

Loading...